Add -Wsign-compare for C++ compilation on linux & friends.
g++ -Wall includes -Wsign-compare on C++ source, but clang++ doesn't.
(this is a 2nd attempt to land this change, after 79846 had to be rolled back
because clang's -Wsign-compare semantics were different from gcc's; this has
been fixed in clang 135664)
BUG=none
TEST=chrome builds w/ rolled clang, trybots
Review URL: http://codereview.chromium.org/7493029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93837 0039d316-1c4b-4281-b951-d872f2087c98
diff --git a/build/common.gypi b/build/common.gypi
index 69a42c6..54654b0 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -1223,6 +1223,10 @@
# Make inline functions have hidden visiblity by default.
# Surprisingly, not covered by -fvisibility=hidden.
'-fvisibility-inlines-hidden',
+ # GCC turns on -Wsign-compare for C++ under -Wall, but clang doesn't,
+ # so we specify it explicitly.
+ # TODO(fischman): remove this if http://llvm.org/PR10448 obsoletes it.
+ '-Wsign-compare',
],
'ldflags': [
'-pthread', '-Wl,-z,noexecstack',
