cc: Remove most methods from RendererClient.
This class is being used to pass data to the Renderer, but it's more
clear if we just pass the data directly when we call DrawFrame.
There are also some interesting round trips where OutputSurface sets
data on the OutputSurfaceClient (LayerTreeHostImpl) which just stores
the data. Then the data is accessed through the RendererClient or
on the LTHI directly, but in places that could just query it from the
OutputSurface directly.
This patch unravels one of these loops with HasExternalStencilTest().
The remaining two getters on RendererClient are called in both DrawFrame
and in SwapBuffers, so I'm not sure if we want to pass them directly to
both functions (redundency is error-prone) or we have some other nice
idea to get rid of them.
R=enne
BUG=
Review URL: https://chromiumcodereview.appspot.com/23961003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222050 0039d316-1c4b-4281-b951-d872f2087c98
diff --git a/cc/test/pixel_test.h b/cc/test/pixel_test.h
index 86a81123..2d5e8ce 100644
--- a/cc/test/pixel_test.h
+++ b/cc/test/pixel_test.h
@@ -42,6 +42,7 @@
const base::FilePath& ref_file,
const PixelComparator& comparator);
+ LayerTreeSettings settings_;
gfx::Size device_viewport_size_;
class PixelTestRendererClient;
scoped_ptr<OutputSurface> output_surface_;
@@ -85,10 +86,12 @@
class GLRendererWithSkiaGPUBackend : public GLRenderer {
public:
GLRendererWithSkiaGPUBackend(RendererClient* client,
- OutputSurface* output_surface,
- ResourceProvider* resource_provider,
- int highp_threshold_min)
+ const LayerTreeSettings* settings,
+ OutputSurface* output_surface,
+ ResourceProvider* resource_provider,
+ int highp_threshold_min)
: GLRenderer(client,
+ settings,
output_surface,
resource_provider,
highp_threshold_min) {}
@@ -99,10 +102,12 @@
class GLRendererWithExpandedViewport : public GLRenderer {
public:
GLRendererWithExpandedViewport(RendererClient* client,
- OutputSurface* output_surface,
- ResourceProvider* resource_provider,
- int highp_threshold_min)
+ const LayerTreeSettings* settings,
+ OutputSurface* output_surface,
+ ResourceProvider* resource_provider,
+ int highp_threshold_min)
: GLRenderer(client,
+ settings,
output_surface,
resource_provider,
highp_threshold_min) {}
@@ -111,14 +116,12 @@
class SoftwareRendererWithExpandedViewport : public SoftwareRenderer {
public:
SoftwareRendererWithExpandedViewport(RendererClient* client,
- OutputSurface* output_surface,
- ResourceProvider* resource_provider)
- : SoftwareRenderer(client,
- output_surface,
- resource_provider) {}
+ const LayerTreeSettings* settings,
+ OutputSurface* output_surface,
+ ResourceProvider* resource_provider)
+ : SoftwareRenderer(client, settings, output_surface, resource_provider) {}
};
-
template<>
inline void RendererPixelTest<GLRenderer>::SetUp() {
SetUpGLRenderer(false);
