Lazy initialization for ProcessesEventRouter.
Make it profile-scoped, not a singleton.
Construct EventRouter at ExtensionSystem creation time.
Implement EventRouter::Observer interface for lazy event router initialization, and use it for processes API.
BUG=156715,159265
[email protected]
Review URL: https://chromiumcodereview.appspot.com/11359081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166813 0039d316-1c4b-4281-b951-d872f2087c98
diff --git a/chrome/browser/extensions/event_router.h b/chrome/browser/extensions/event_router.h
index cbfb1b8..94f81da 100644
--- a/chrome/browser/extensions/event_router.h
+++ b/chrome/browser/extensions/event_router.h
@@ -22,7 +22,6 @@
#include "ipc/ipc_sender.h"
class GURL;
-class ExtensionDevToolsManager;
class Profile;
namespace content {
@@ -47,6 +46,16 @@
USER_GESTURE_NOT_ENABLED = 2,
};
+ // Observers register interest in events with a particular name and are
+ // notified when a listener is added or removed for that |event_name|.
+ class Observer {
+ public:
+ // Called when a listener is added.
+ virtual void OnListenerAdded(const std::string& event_name) {}
+ // Called when a listener is removed.
+ virtual void OnListenerRemoved(const std::string& event_name) {}
+ };
+
// Sends an event via ipc_sender to the given extension. Can be called on any
// thread.
static void DispatchEvent(IPC::Sender* ipc_sender,
@@ -73,6 +82,15 @@
EventListenerMap& listeners() { return listeners_; }
+ // Registers an observer to be notified when an event listener for
+ // |event_name| is added or removed. There can currently be only one observer
+ // for each distinct |event_name|.
+ void RegisterObserver(Observer* observer,
+ const std::string& event_name);
+
+ // Unregisters an observer from all events.
+ void UnregisterObserver(Observer* observer);
+
// Add or remove the extension as having a lazy background page that listens
// to the event. The difference from the above methods is that these will be
// remembered even after the process goes away. We use this list to decide
@@ -249,10 +267,11 @@
content::NotificationRegistrar registrar_;
- scoped_refptr<ExtensionDevToolsManager> extension_devtools_manager_;
-
EventListenerMap listeners_;
+ typedef std::map<std::string, Observer*> ObserverMap;
+ ObserverMap observers_;
+
// True if we should dispatch the event signalling that Chrome was updated
// upon loading an extension.
bool dispatch_chrome_updated_event_;
