Improve error messages from checkperms PRESUBMIT check
BUG=423697
Review URL: https://codereview.chromium.org/1395493002
Cr-Commit-Position: refs/heads/master@{#353993}
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index be7dccf..900e7c9 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -656,13 +656,13 @@
'--root', input_api.change.RepositoryRoot()]
for f in input_api.AffectedFiles():
args += ['--file', f.LocalPath()]
- checkperms = input_api.subprocess.Popen(args,
- stdout=input_api.subprocess.PIPE)
- errors = checkperms.communicate()[0].strip()
- if errors:
- return [output_api.PresubmitError('checkperms.py failed.',
- errors.splitlines())]
- return []
+ try:
+ input_api.subprocess.check_output(args)
+ return []
+ except input_api.subprocess.CalledProcessError as error:
+ return [output_api.PresubmitError(
+ 'checkperms.py failed:',
+ long_text=error.output)]
def _CheckNoAuraWindowPropertyHInHeaders(input_api, output_api):
