Make having a reserved file/folder name when installing a packed extension a warning instead of fatal error.
BUG=274722
Review URL: https://chromiumcodereview.appspot.com/23264019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218830 0039d316-1c4b-4281-b951-d872f2087c98
diff --git a/chrome/browser/extensions/extension_service_unittest.cc b/chrome/browser/extensions/extension_service_unittest.cc
index aa1f61f2..b16dc3b 100644
--- a/chrome/browser/extensions/extension_service_unittest.cc
+++ b/chrome/browser/extensions/extension_service_unittest.cc
@@ -1590,13 +1590,11 @@
InstallCRX(path, INSTALL_FAILED);
ValidatePrefKeyCount(pref_count);
- // Extensions cannot have folders or files that have underscores except in
- // certain whitelisted cases (eg _locales). This is an example of a broader
- // class of validation that we do to the directory structure of the extension.
- // We did not used to handle this correctly for installation.
+ // Packed extensions may have folders or files that have underscores.
+ // This will only cause a warning, rather than a fatal error.
path = data_dir_.AppendASCII("bad_underscore.crx");
- InstallCRX(path, INSTALL_FAILED);
- ValidatePrefKeyCount(pref_count);
+ InstallCRX(path, INSTALL_NEW);
+ ValidatePrefKeyCount(++pref_count);
// TODO(erikkay): add more tests for many of the failure cases.
// TODO(erikkay): add tests for upgrade cases.
