| commit | 75dbb325f67ab6e42c5cdca7aa9084f33b67eae3 | [log] [tgz] |
|---|---|---|
| author | Etienne Pierre-doray <[email protected]> | Thu May 30 10:46:41 2019 |
| committer | Commit Bot <[email protected]> | Thu May 30 10:46:41 2019 |
| tree | 2169a55d397ba1070becc51c8986970d8b92d3c2 | |
| parent | 0494f2d2b1ea89015cf6eae7bb367259eb7e56de [diff] |
[Scheduler]: Revamp SequenceLocalStorage.
This CL fixes a few issues with SequenceLocalStorage:
- Supports holding T with disabled copy/move constructor
by adding emplace().
- Prevents auto default construction with GetValuePointer.
- Query if SequenceLocalStorageSlot currently holds a value
with operator bool().
- Update doc to use NoDestructor.
This makes it possible to replace in many cases:
SequenceLocalStorageSlot<unique_ptr<T>> with
SequenceLocalStorageSlot<T>
and
auto ptr = sls.Get();
if (!ptr) {
ptr = make_unique<T>();
sls.Set(ptr);
}
return *ptr;
with
return sls.GetOrCreateValue();
[email protected]
Change-Id: I0473fbb4eded35177aa32fabb5377b0cad648c16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634876
Commit-Queue: Etienne Pierre-Doray <[email protected]>
Reviewed-by: François Doray <[email protected]>
Cr-Commit-Position: refs/heads/master@{#664708}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .