| commit | 67848525e5578a7fd49491230b4e6e6baf163020 | [log] [tgz] |
|---|---|---|
| author | Daniel Cheng <[email protected]> | Fri Apr 27 22:04:41 2018 |
| committer | Commit Bot <[email protected]> | Fri Apr 27 22:04:41 2018 |
| tree | 5720cda6071b9a78580268bfa66a471eca8b8988 | |
| parent | c71746a66a2b601de8221d3a762da638f0ed2b90 [diff] [blame] |
Chrome style plugin: enable virtual specifier checks for Gmock objects in //components Previously, the plugin completely skipped virtual specifier checks on Gmock objects since it wasn't smart enough to filter out warnings caused by Gmock macros. In preparation for making the plugin smarter, this CL fixes existing virtual specifier warnings in //components. [email protected] Bug: 837148 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I14f72dd481c02acdc8ea35d58d9fb4801140d353 Reviewed-on: https://chromium-review.googlesource.com/1031090 Commit-Queue: Daniel Cheng <[email protected]> Reviewed-by: Jochen Eisinger <[email protected]> Cr-Commit-Position: refs/heads/master@{#554524}
diff --git a/components/prefs/pref_notifier_impl_unittest.cc b/components/prefs/pref_notifier_impl_unittest.cc index 06ab053..a76c933 100644 --- a/components/prefs/pref_notifier_impl_unittest.cc +++ b/components/prefs/pref_notifier_impl_unittest.cc
@@ -49,7 +49,7 @@ public: explicit MockPrefNotifier(PrefService* pref_service) : PrefNotifierImpl(pref_service) {} - virtual ~MockPrefNotifier() {} + ~MockPrefNotifier() override {} MOCK_METHOD1(FireObservers, void(const std::string& path));