Google Git
Sign in
chromium / chromium / src / 68638d404b911ac4628124c83d9614e037a5e3b4
commit68638d404b911ac4628124c83d9614e037a5e3b4[log] [tgz]
authorKen Rockot <[email protected]>Thu Nov 01 03:30:13 2018
committerCommit Bot <[email protected]>Thu Nov 01 03:30:13 2018
tree2775a6792d0105de7eb1219977e5a817f16357ae
parentfcc8145a50852fde3bfca6d6c934fd3f585bc204 [diff]
Port omnibox WebUI to new JS mojom bindings

Usage of the old bindings required loading about 185 kB of JS,
including 155 kB from the common bindings library (mojo_bindings.js)
as well as another ~30 kB from the JS generated by omnibox.mojom.

With the new bindings, the common library is only 21 kB compiled
and the generated JS for omnibox.mojom 16 kB (uncompiled, with lots
of Closure annotations). Net mojom-supporting code size reduction of
80%, with room to improve once we compile generated code too.

Also fixes a long-standing bug in the omnibox JS where the selected
page classification value was not being used.

Bug: 894376
Change-Id: Ie6c5450b7df3b7e7ac29cf68d9a1532c9365046c
Reviewed-on: https://chromium-review.googlesource.com/c/1289701
Commit-Queue: Ken Rockot <[email protected]>
Reviewed-by: Demetrios Papadopoulos <[email protected]>
Cr-Commit-Position: refs/heads/master@{#604509}
7 files changed
tree: 2775a6792d0105de7eb1219977e5a817f16357ae
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. webrunner/
  53. .clang-format
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. AUTHORS
  61. BUILD.gn
  62. CODE_OF_CONDUCT.md
  63. codereview.settings
  64. DEPS
  65. ENG_REVIEW_OWNERS
  66. LICENSE
  67. LICENSE.chromium_os
  68. OWNERS
  69. PRESUBMIT.py
  70. PRESUBMIT_test.py
  71. PRESUBMIT_test_mocks.py
  72. README.md
  73. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .