| commit | 6945181f25928f61c2fe0eedbc96b056c2255223 | [log] [tgz] |
|---|---|---|
| author | Mustafa Emre Acer <[email protected]> | Wed Aug 07 18:14:26 2019 |
| committer | Commit Bot <[email protected]> | Wed Aug 07 18:14:26 2019 |
| tree | cdd551ca0cdcabc72ff254b22e08ca294a78227f | |
| parent | 2e075ed1cf31c05d23f25d72ea0d914c3aac1fd2 [diff] [blame] |
Add initial page info implementation for safety tips This CL updates the page info bubble to display information about safety tips that were shown when the page was loaded. The safety tip status is stored in the visible security state of the page and read by page info bubble when it's displayed. Screenshot: https://drive.google.com/file/d/1r6kOdovGbqAdX0_mU11yDKYnVx0AiSGA/view?usp=sharing Bug: 990929 Change-Id: Ia052f7941e538bc2d18526da0d9f3a7d71742f79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735900 Commit-Queue: Mustafa Emre Acer <[email protected]> Reviewed-by: Christopher Thompson <[email protected]> Reviewed-by: Joe DeBlasio <[email protected]> Cr-Commit-Position: refs/heads/master@{#684839}
diff --git a/components/page_info_strings.grdp b/components/page_info_strings.grdp index 532169e3..528271f 100644 --- a/components/page_info_strings.grdp +++ b/components/page_info_strings.grdp
@@ -45,6 +45,9 @@ <message name="IDS_PAGE_INFO_SAFETY_TIP_LEAVE_BUTTON" desc="Text of button to leave a suspicious page shown on the safety tip page info bubble."> Leave this site </message> + <message name="IDS_PAGE_INFO_SAFETY_TIP_SUMMARY" desc="Message to display in the page info bubble when the page you are on triggered a safety tip."> + Suspicious site + </message> <!-- Viewing file strings --> <message name="IDS_PAGE_INFO_FILE_PAGE" desc="Message to display in the page info bubble when the page the user has navigated to is a file:// page">