| commit | 694b50a9d759601471f5b8c8d61bd488b6a4cfba | [log] [tgz] |
|---|---|---|
| author | xjz <[email protected]> | Tue Jun 07 21:49:37 2016 |
| committer | Commit bot <[email protected]> | Tue Jun 07 21:52:21 2016 |
| tree | ac420b6cbbc195b13fdd0a50e55e0986d49bf7a9 | |
| parent | b9e16a70339082317d07db9f4165e10257723a28 [diff] [blame] |
Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual. All subclasses must implement the method, even if it should be empty. This would ensure the compiler makes a developer aware of the lifecycle concerns around RenderFrame/RenderView, and avoid the unintended transfering ownership when inheriting the observer interface. BUG=616214 Review-Url: https://codereview.chromium.org/2034153002 Cr-Commit-Position: refs/heads/master@{#398395}
diff --git a/content/shell/renderer/shell_render_view_observer.h b/content/shell/renderer/shell_render_view_observer.h index 6e66d8dc..8d653da 100644 --- a/content/shell/renderer/shell_render_view_observer.h +++ b/content/shell/renderer/shell_render_view_observer.h
@@ -25,6 +25,7 @@ private: // RenderViewObserver implementation. void DidClearWindowObject(blink::WebLocalFrame* frame) override; + void OnDestruct() override; DISALLOW_COPY_AND_ASSIGN(ShellRenderViewObserver); };