[TaskScheduler] Make PackExtensionJob run on sequences.
It used to run on FILE thread, which is deprecated.
This CL also removes ref-counting from PackExtensionJob, as
PackExtensionJob::Client should be responsible for keeping
PackExtensionJob alive.
Change set_asynchronous(bool) -> set_synchronous as async is
the default, and set_synchronous was always called with false.
Bug: 689520
Change-Id: I87143df26e7adf28bbbe6fd379a38d17d07cb967
Reviewed-on: https://chromium-review.googlesource.com/611044
Commit-Queue: Istiaque Ahmed <[email protected]>
Reviewed-by: Devlin <[email protected]>
Cr-Commit-Position: refs/heads/master@{#493900}diff --git a/chrome/browser/extensions/extension_service_unittest.cc b/chrome/browser/extensions/extension_service_unittest.cc
index 9be8d26..07c82e0 100644
--- a/chrome/browser/extensions/extension_service_unittest.cc
+++ b/chrome/browser/extensions/extension_service_unittest.cc
@@ -1912,18 +1912,20 @@
temp_dir.GetPath().Append(expected_private_key_names[i]);
PackExtensionTestClient pack_client(expected_crx_path,
expected_private_key_path);
- scoped_refptr<extensions::PackExtensionJob> packer(
- new extensions::PackExtensionJob(&pack_client, output_dir,
- base::FilePath(),
- ExtensionCreator::kOverwriteCRX));
- packer->Start();
+ {
+ extensions::PackExtensionJob packer(&pack_client, output_dir,
+ base::FilePath(),
+ ExtensionCreator::kOverwriteCRX);
+ packer.Start();
- // The packer will post a notification task to the current thread's message
- // loop when it is finished. We manually run the loop here so that we
- // block and catch the notification; otherwise, the process would exit.
- // This call to |Run()| is matched by a call to |Quit()| in the
- // |PackExtensionTestClient|'s notification handling code.
- base::RunLoop().Run();
+ // The packer will post a notification task to the current thread's
+ // message loop when it is finished. We manually run the loop here so
+ // that we block and catch the notification; otherwise, the process would
+ // exit.
+ // This call to |Run()| is matched by a call to |Quit()| in the
+ // |PackExtensionTestClient|'s notification handling code.
+ base::RunLoop().Run();
+ }
if (HasFatalFailure())
return;
