Revert 236583 "Re-enable browser_tests NaClExtensionTest."
Broke the bot:
http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg%29%284%29/builds/35451/steps/browser_tests/logs/UnpackedExtension
like this:
NaClExtensionTest.UnpackedExtension:
[6164:23811:1121/131719:1565194712237:ERROR:transport_security_persister.cc(308)] Failed to deserialize state:
objc[6165]: Class MockCrApp is implemented in both /Volumes/data/b/build/slave/Mac_10_6_Tests__dbg__4_/build/src/out/Debug/./libwebkit.dylib and /Volumes/data/b/build/slave/Mac_10_6_Tests__dbg__4_/build/src/out/Debug/Chromium.app/Contents/Versions/33.0.1716.0/Chromium Helper.app/Contents/MacOS/../../../../../../../libchrome_main_dll.dylib. One of the two will be used. Which one is undefined.
HTTP server started on 127.0.0.1:55238...
sending server_data: {"host": "127.0.0.1", "port": 55238} (36 bytes)
objc[6167]: Class MockCrApp is implemented in both /Volumes/data/b/build/slave/Mac_10_6_Tests__dbg__4_/build/src/out/Debug/./libwebkit.dylib and /Volumes/data/b/build/slave/Mac_10_6_Tests__dbg__4_/build/src/out/Debug/Chromium.app/Contents/Versions/33.0.1716.0/Chromium Helper EH.app/Contents/MacOS/../../../../../../../libchrome_main_dll.dylib. One of the two will be used. Which one is undefined.
objc[6168]: Class MockCrApp is implemented in both /Volumes/data/b/build/slave/Mac_10_6_Tests__dbg__4_/build/src/out/Debug/./libwebkit.dylib and /Volumes/data/b/build/slave/Mac_10_6_Tests__dbg__4_/build/src/out/Debug/Chromium.app/Contents/Versions/33.0.1716.0/Chromium Helper.app/Contents/MacOS/../../../../../../../libchrome_main_dll.dylib. One of the two will be used. Which one is undefined.
[6164:263:1121/131721:1566617402523:INFO:CONSOLE(0)] "NativeClient: NaCl module load failed: could not load manifest url.", source: chrome-extension://bjjcibdiodkkeanflmiijlcfieiemced/test.html (0)
[6164:263:1121/131721:1566618629009:INFO:CONSOLE(0)] "NativeClient: NaCl module load failed: could not load manifest url.", source: chrome-extension://bjjcibdiodkkeanflmiijlcfieiemced/test.html (0)
../../chrome/browser/extensions/extension_nacl_browsertest.cc:136: Failure
Value of: (expected_to_succeed & PLUGIN_TYPE_EMBED) != 0
Actual: true
Expected: embedded_plugin_created
Which is: false
> Re-enable browser_tests NaClExtensionTest.
> These were recently disabled but appear to be working now,
> so perhaps some NaCl issue caused this.
>
> BUG=319892
>
> Review URL: https://codereview.chromium.org/76913002
[email protected]
Review URL: https://codereview.chromium.org/81433003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236596 0039d316-1c4b-4281-b951-d872f2087c98
diff --git a/chrome/browser/extensions/extension_nacl_browsertest.cc b/chrome/browser/extensions/extension_nacl_browsertest.cc
index ba724d5..2f4652b 100644
--- a/chrome/browser/extensions/extension_nacl_browsertest.cc
+++ b/chrome/browser/extensions/extension_nacl_browsertest.cc
@@ -147,7 +147,8 @@
};
// Test that the NaCl plugin isn't blocked for Webstore extensions.
-IN_PROC_BROWSER_TEST_F(NaClExtensionTest, WebStoreExtension) {
+// Disabled: http://crbug.com/319892
+IN_PROC_BROWSER_TEST_F(NaClExtensionTest, DISABLED_WebStoreExtension) {
ASSERT_TRUE(test_server()->Start());
const Extension* extension = InstallExtension(INSTALL_TYPE_FROM_WEBSTORE);
@@ -156,7 +157,8 @@
}
// Test that the NaCl plugin is blocked for non-Webstore extensions.
-IN_PROC_BROWSER_TEST_F(NaClExtensionTest, NonWebStoreExtension) {
+// Disabled: http://crbug.com/319892
+IN_PROC_BROWSER_TEST_F(NaClExtensionTest, DISABLED_NonWebStoreExtension) {
ASSERT_TRUE(test_server()->Start());
const Extension* extension = InstallExtension(INSTALL_TYPE_NON_WEBSTORE);
@@ -165,7 +167,8 @@
}
// Test that the NaCl plugin isn't blocked for component extensions.
-IN_PROC_BROWSER_TEST_F(NaClExtensionTest, ComponentExtension) {
+// Disabled: http://crbug.com/319892
+IN_PROC_BROWSER_TEST_F(NaClExtensionTest, DISABLED_ComponentExtension) {
ASSERT_TRUE(test_server()->Start());
const Extension* extension = InstallExtension(INSTALL_TYPE_COMPONENT);
@@ -175,7 +178,8 @@
}
// Test that the NaCl plugin isn't blocked for unpacked extensions.
-IN_PROC_BROWSER_TEST_F(NaClExtensionTest, UnpackedExtension) {
+// Disabled: http://crbug.com/319892
+IN_PROC_BROWSER_TEST_F(NaClExtensionTest, DISABLED_UnpackedExtension) {
ASSERT_TRUE(test_server()->Start());
const Extension* extension = InstallExtension(INSTALL_TYPE_UNPACKED);
@@ -186,7 +190,8 @@
// Test that the NaCl plugin is blocked for non chrome-extension urls, except
// if it's a content (MIME type) handler.
-IN_PROC_BROWSER_TEST_F(NaClExtensionTest, NonExtensionScheme) {
+// Disabled: http://crbug.com/319892
+IN_PROC_BROWSER_TEST_F(NaClExtensionTest, DISABLED_NonExtensionScheme) {
ASSERT_TRUE(test_server()->Start());
const Extension* extension = InstallExtension(INSTALL_TYPE_FROM_WEBSTORE);
