Google Git
Sign in
chromium / chromium / src / 728cd3a19fa4e1876e9bfcab9cf3bf52514460c6
commit728cd3a19fa4e1876e9bfcab9cf3bf52514460c6[log] [tgz]
authorEtienne Bergeron <[email protected]>Fri Aug 02 22:34:25 2019
committerCommit Bot <[email protected]>Fri Aug 02 22:34:25 2019
treedc692747c188db975067cba34d2e7cdc24727b9f
parent6f6005037957af633b2cc6c1ca7aefb30e66d28d [diff]
Keep font styles for system fonts

This CL is fixing the imports of the system fonts. The previous code
was not taking care of the font styles.

The bug was introduced here:
 https://chromium-review.googlesource.com/c/chromium/src/+/1544229

The system font is created only by it's name and size:
 return Font(PlatformFont::CreateFromNameAndSize(font_name, font_size));

Some users are overriding the system font with a custom one. That font
may have some styles. The default windows configuration doesn't allow
to change the font styles, but advanced fonts software may do.

  Advanced System Font Changer:
  https://www.wintools.info/index.php/advanced-system-font-changer-icon-settings

[email protected],[email protected]

Bug: 989476
Change-Id: Ie88ccf4452c5156de48e4f4a4bda87bd167850e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732733
Reviewed-by: Alexei Svitkine <[email protected]>
Reviewed-by: Robert Liao <[email protected]>
Commit-Queue: Etienne Bergeron <[email protected]>
Cr-Commit-Position: refs/heads/master@{#683774}
3 files changed
tree: dc692747c188db975067cba34d2e7cdc24727b9f
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. .clang-format
  52. .eslintrc.js
  53. .git-blame-ignore-revs
  54. .gitattributes
  55. .gitignore
  56. .gn
  57. .vpython
  58. AUTHORS
  59. BUILD.gn
  60. CODE_OF_CONDUCT.md
  61. codereview.settings
  62. DEPS
  63. ENG_REVIEW_OWNERS
  64. LICENSE
  65. LICENSE.chromium_os
  66. OWNERS
  67. PRESUBMIT.py
  68. PRESUBMIT_test.py
  69. PRESUBMIT_test_mocks.py
  70. README.md
  71. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .