Reland "Clear inapplicable disable reasons for component extensions"
This reverts commit b8de8c26b45a57af7220b867893130eab195d824.
Reason for revert: Relanding: Looks like the problem is caused by another CL.
Original change's description:
> Revert "Clear inapplicable disable reasons for component extensions"
>
> This reverts commit 07619eb11e0262154fd0bc07a338d45ce6c90489.
>
> Reason for revert: Speculative revert for "Linux Chromium OS ASan LSan Tests (1)" failures in unit_tests related to extensions.
>
> Original change's description:
> > Clear inapplicable disable reasons for component extensions
> >
> > This change ensures that all component extensions are allowed to be activated despite having some inapplicable disable reasons set.
> >
> > In particular, this fixes any specific observed on-device instances where ChromeVox or tts had a disable reason of blocked by policy which prevented it from being activated.
> >
> > Bug: 946839,947305
> > Test: manually. With a device enterprise enrolled, push down kiosk apps to the device from an admin console. Ensure that ChromeVox still works on all screens.
> > Change-Id: I2cedafeb16d4420702188f1516825ce1bad52802
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553017
> > Commit-Queue: David Tseng <[email protected]>
> > Reviewed-by: Devlin <[email protected]>
> > Cr-Commit-Position: refs/heads/master@{#648464}
>
> [email protected],[email protected],[email protected]
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: 946839, 947305
> Change-Id: Icf19fe7e45c41ed559a732703844c0874c6cfdd4
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557734
> Reviewed-by: Samuel Huang <[email protected]>
> Commit-Queue: Samuel Huang <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#648573}
[email protected],[email protected],[email protected],[email protected]
Change-Id: I92b60a51aaf4883e8fcc953645b343860bb61f1e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 946839, 947305
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557011
Reviewed-by: Samuel Huang <[email protected]>
Commit-Queue: Samuel Huang <[email protected]>
Cr-Commit-Position: refs/heads/master@{#648632}diff --git a/chrome/browser/extensions/extension_service.cc b/chrome/browser/extensions/extension_service.cc
index 3b26e20..caeefb2 100644
--- a/chrome/browser/extensions/extension_service.cc
+++ b/chrome/browser/extensions/extension_service.cc
@@ -1208,6 +1208,8 @@
}
void ExtensionService::AddComponentExtension(const Extension* extension) {
+ extension_prefs_->ClearInapplicableDisableReasonsForComponentExtension(
+ extension->id());
const std::string old_version_string(
extension_prefs_->GetVersionString(extension->id()));
const base::Version old_version(old_version_string);
