Re-revert of Flip extension background page throttling on by default (patchset #1 id:1 of https://codereview.chromium.org/1163983004/)
Reason for revert:
Reverting due to crbug.com/487201 while we decide on a solution.
Original issue's description:
> Revert of Revert of Revert of Revert of Flip extension background page throttling on by default (patchset #1 id:1 of https://codereview.chromium.org/1159353003/)
>
> Reason for revert:
> Fixed in https://codereview.chromium.org/1149213005
>
> Original issue's description:
> > Revert of Revert of Revert of Flip extension background page throttling on by default (patchset #1 id:1 of https://codereview.chromium.org/1161773008/)
> >
> > Reason for revert:
> > Speculative revert. In https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/6475 this is the only non-reverted CL looking related to the browser_tests failures.
> >
> > Original issue's description:
> > > Revert of Revert of Flip extension background page throttling on by default (patchset #1 id:1 of https://codereview.chromium.org/1106953002/)
> > >
> > > Reason for revert:
> > > Re-landing, tests fixed in https://codereview.chromium.org/1108133002/
> > >
> > > Original issue's description:
> > > > Revert of Flip extension background page throttling on by default (patchset #2 id:20001 of https://codereview.chromium.org/1106653002/)
> > > >
> > > > Reason for revert:
> > > > Speculative revert - multiple browser_tests fail on Mac10.9 Tests (dbg)
> > > > http://goo.gl/4AqhVG
> > > >
> > > > Original issue's description:
> > > > > Flip extension background page throttling on by default
> > > > >
> > > > > R=kalman
> > > > > BUG=424661
> > > > >
> > > > > Committed: https://crrev.com/34ea66b8ac1d56dadd670a9f5f8431063857ffdd
> > > > > Cr-Commit-Position: refs/heads/master@{#326953}
> > > >
> > > > [email protected],[email protected]
> > > > NOPRESUBMIT=true
> > > > NOTREECHECKS=true
> > > > NOTRY=true
> > > > BUG=424661
> > > >
> > > > Committed: https://crrev.com/76a7e3446188256ca240dc31cd5287ef78de2951
> > > > Cr-Commit-Position: refs/heads/master@{#327021}
> > >
> > > [email protected],[email protected]
> > > NOPRESUBMIT=true
> > > NOTREECHECKS=true
> > > NOTRY=true
> > > BUG=424661
> > >
> > > Committed: https://crrev.com/c5a5ee158569102adcdbcca961d39505a78199e8
> > > Cr-Commit-Position: refs/heads/master@{#332062}
> >
> > [email protected],[email protected],[email protected]
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=424661
> >
> > Committed: https://crrev.com/1dc291c2a9bc0b54563f6971fff203a9d3a4f44e
> > Cr-Commit-Position: refs/heads/master@{#332163}
>
> [email protected],[email protected],[email protected]
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=424661
>
> Committed: https://crrev.com/1649e5b362ab55bae8d8ff0ad9c0706909651353
> Cr-Commit-Position: refs/heads/master@{#332784}
[email protected],[email protected],[email protected]
BUG=424661
Review URL: https://codereview.chromium.org/1186693002
Cr-Commit-Position: refs/heads/master@{#334270}
diff --git a/extensions/browser/extension_host.cc b/extensions/browser/extension_host.cc
index c3e041a..f681d3f 100644
--- a/extensions/browser/extension_host.cc
+++ b/extensions/browser/extension_host.cc
@@ -156,9 +156,12 @@
"464206 ExtensionHost::CreateRenderViewNow2"));
DCHECK(IsRenderViewLive());
if (extension_) {
- if (extensions::BackgroundInfo::HasPersistentBackgroundPage(extension_) &&
- base::FieldTrialList::FindFullName(
- "ThrottleExtensionBackgroundPages") != "Disabled") {
+ std::string group_name = base::FieldTrialList::FindFullName(
+ "ThrottleExtensionBackgroundPages");
+ if ((group_name == "ThrottlePersistent" &&
+ extensions::BackgroundInfo::HasPersistentBackgroundPage(
+ extension_)) ||
+ group_name == "ThrottleAll") {
host_contents_->WasHidden();
}
}
