Up the warnings in ipc (take 2)
- add chromium_code:1 to the GYP file
- Fix some unittest compares of literal 0 to apis that return size_t
- initializer order match declared order
- type_id is a uint32, so fix up comparison warnings by using the right type in the test code.
- duplicate a type cast used in the ipc headers into the ipc impl to make windows happy.
- msvc warns about getenv, avoid it.
BUG=none
TEST=everything still builds/works
Review URL: http://codereview.chromium.org/2821028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53468 0039d316-1c4b-4281-b951-d872f2087c98
diff --git a/ipc/sync_socket_unittest.cc b/ipc/sync_socket_unittest.cc
index 8681eb7..d37247d13 100644
--- a/ipc/sync_socket_unittest.cc
+++ b/ipc/sync_socket_unittest.cc
@@ -194,7 +194,7 @@
socket_->Receive(static_cast<void*>(buf), kHelloStringLength);
EXPECT_EQ(strcmp(str.c_str(), buf), 0);
// After receiving from the socket there should be no bytes left.
- EXPECT_EQ(0, socket_->Peek());
+ EXPECT_EQ(0U, socket_->Peek());
IPC::Message* msg = new MsgClassShutdown();
EXPECT_TRUE(chan_->Send(msg));
MessageLoop::current()->Quit();
@@ -219,8 +219,8 @@
base::SyncSocket* pair[2];
base::SyncSocket::CreatePair(pair);
// Immediately after creation there should be no pending bytes.
- EXPECT_EQ(0, pair[0]->Peek());
- EXPECT_EQ(0, pair[1]->Peek());
+ EXPECT_EQ(0U, pair[0]->Peek());
+ EXPECT_EQ(0U, pair[1]->Peek());
base::SyncSocket::Handle target_handle;
// Connect the channel and listener.
ASSERT_TRUE(chan.Connect());
