| commit | 806691b1b1b3f21668e2ce493f7e0015732398e0 | [log] [tgz] |
|---|---|---|
| author | Chris Watkins <[email protected]> | Fri Dec 01 06:01:22 2017 |
| committer | Commit Bot <[email protected]> | Fri Dec 01 06:01:22 2017 |
| tree | 1655dd6b39eeeeec9b9d954e572293aca0643599 | |
| parent | 813190a7045c2226aa6f1a4c9156888038bd9c48 [diff] [blame] |
Run clang-tidy modernize-use-equals-{delete,default} on //net/reporting
See the bugs and cxx post for justification and details:
https://groups.google.com/a/chromium.org/forum/#!topic/cxx/RkOHzIK6Tq8
This change was done using clang-tidy as described here:
https://chromium.googlesource.com/chromium/src/+/lkcr/docs/clang_tidy.md
In some cases the the tool leaves behind a string of commas where it
replaced a member initializer list
(https://bugs.llvm.org/show_bug.cgi?id=35051). They were cleaned up with:
git diff --name-only | \
xargs sed -E -i 's/(^\s*|\)\s*):[ ,]*= default/\1 = default/'
BUG=778959,778957
This CL was uploaded by git cl split.
[email protected]
Change-Id: Ib3962b07d49ab4e0032abc2fa61fa35faee70971
Reviewed-on: https://chromium-review.googlesource.com/799590
Reviewed-by: Julia Tuttle <[email protected]>
Commit-Queue: Chris Watkins <[email protected]>
Cr-Commit-Position: refs/heads/master@{#520866}diff --git a/net/reporting/reporting_service.cc b/net/reporting/reporting_service.cc index e72eb752..935fd6d 100644 --- a/net/reporting/reporting_service.cc +++ b/net/reporting/reporting_service.cc
@@ -28,7 +28,7 @@ ReportingServiceImpl(std::unique_ptr<ReportingContext> context) : context_(std::move(context)) {} - ~ReportingServiceImpl() override {} + ~ReportingServiceImpl() override = default; void QueueReport(const GURL& url, const std::string& group, @@ -61,7 +61,7 @@ } // namespace -ReportingService::~ReportingService() {} +ReportingService::~ReportingService() = default; // static std::unique_ptr<ReportingService> ReportingService::Create(