Reland "[webauthn] Don't configure hybrid on new Win11"
This reverts commit fa84a99a9a98b95f5f9c0540c49697ebca6113a6.
The first attempt broke tests because the testing infrastructure
depends on hybrid discovery callbacks to be set. This attempt takes a
different approach and configures the discovery but does not return
it when supported by Windows. This is a more direct way to accomplish
approximately the same thing.
See diff against PS#1 for changes.
Original change's description:
> Revert "[webauthn] Don't configure hybrid on new Win11"
>
> This reverts commit 625be3885365eb860835bf988007840418aa250a.
>
> Reason for revert: breaks win-arm64-rel-ready
>
> Original change's description:
> > [webauthn] Don't configure hybrid on new Win11
> >
> > Skip configuring hybrid on recent enough versions of Windows 11 that do
> > hybrid. This was always intended to be the case, but I accidentally
> > unshipped the feature with passkey metadata syncing.
> >
> > This CL also bumps the minimum required WebAuthn DLL version for
> > hybrid to 7, which supports sending linking information and is
> > required to support phones linked from sync.
> >
> > Added a flag that can be used as a kill switch if things go awry.
> >
> > Fixed: 377324982
> > Change-Id: If902c95cbbf92dcea2c18d42e8243464c77f655a
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5994693
> > Auto-Submit: Nina Satragno <[email protected]>
> > Reviewed-by: Adam Langley <[email protected]>
> > Commit-Queue: Adam Langley <[email protected]>
> > Cr-Commit-Position: refs/heads/main@{#1379095}
>
> Change-Id: I32e0e7b4877a7bd893d874a4e23a57e360a0948e
> Bug: 377723875
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6001533
> Owners-Override: Sean Maher <[email protected]>
> Reviewed-by: Adam Langley <[email protected]>
> Commit-Queue: Nina Satragno <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1379259}
Fixed: 377723875, 377324982
Cq-Include-Trybots: luci.chromium.try:win-arm64-rel
Change-Id: Ie4ade9ee6cdf36c14535570a7fa74f082ae1bf2c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6000820
Auto-Submit: Nina Satragno <[email protected]>
Reviewed-by: Adam Langley <[email protected]>
Commit-Queue: Nina Satragno <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1379990}
diff --git a/device/BUILD.gn b/device/BUILD.gn
index abf5968..ac6b04e6 100644
--- a/device/BUILD.gn
+++ b/device/BUILD.gn
@@ -193,6 +193,7 @@
"fido/fake_fido_discovery_unittest.cc",
"fido/fido_device_authenticator_unittest.cc",
"fido/fido_device_discovery_unittest.cc",
+ "fido/fido_discovery_factory_unittest.cc",
"fido/fido_parsing_utils_unittest.cc",
"fido/fido_request_handler_unittest.cc",
"fido/filter_unittest.cc",
