| commit | 88c375837d0f16c412839bb6dd1326312d607bb8 | [log] [tgz] |
|---|---|---|
| author | estade <[email protected]> | Mon Jul 18 22:25:50 2016 |
| committer | Commit bot <[email protected]> | Mon Jul 18 22:28:34 2016 |
| tree | 1c3b572934357626ed341485320ddc9e32ce2721 | |
| parent | 165732a4b1dec1676bf479f2fed9a8df2a73316f [diff] [blame] |
Revert of Replace CONTROL_BACKGROUND and DETACHED_BOOKMARK_BAR_BACKGROUND by COLOR_NTP_BACKGROUND (patchset #8 id:140001 of https://codereview.chromium.org/2062353002/ ) Reason for revert: caused regression: crbug.com/628970 Original issue's description: > Replace CONTROL_BACKGROUND and DETACHED_BOOKMARK_BAR_BACKGROUND by COLOR_NTP_BACKGROUND > > This fixes issues where the ntp background image was > interrupted underneath the detached bookmark bar. > > Also the ntp_background color is now forced to be opaque > even if a none opaque alpha value is provided from the > theme. This prevent issues with subpixel AA which does not > work on none opaque background. (and to avoid falling back > to grayscale AA) > > Also see crbug.com/618278 > > BUG=618335 > > [email protected], [email protected] > > Committed: https://crrev.com/bb4e97590966ba4138b759b8a6450e526a24fa27 > Cr-Commit-Position: refs/heads/master@{#405725} [email protected],[email protected] # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=618335 Review-Url: https://codereview.chromium.org/2159833002 Cr-Commit-Position: refs/heads/master@{#406118}
diff --git a/chrome/browser/themes/theme_service.cc b/chrome/browser/themes/theme_service.cc index 5ffd491e..3abfc22 100644 --- a/chrome/browser/themes/theme_service.cc +++ b/chrome/browser/themes/theme_service.cc
@@ -468,6 +468,10 @@ if (UsingDefaultTheme()) break; return GetColor(ThemeProperties::COLOR_BOOKMARK_TEXT, incognito); + case ThemeProperties::COLOR_DETACHED_BOOKMARK_BAR_BACKGROUND: + if (UsingDefaultTheme()) + break; + return GetColor(ThemeProperties::COLOR_TOOLBAR, incognito); case ThemeProperties::COLOR_DETACHED_BOOKMARK_BAR_SEPARATOR: if (UsingDefaultTheme()) break;