| commit | 88fd9b151a38fa7dbb90cb15b2e01634c08a2f58 | [log] [tgz] |
|---|---|---|
| author | Jeroen Dhollander <[email protected]> | Mon Dec 23 19:54:30 2019 |
| committer | Commit Bot <[email protected]> | Mon Dec 23 19:54:30 2019 |
| tree | 425d2abce235df5327aec3dab14c23ff9e58cbb1 | |
| parent | 8b85759ba0d1189caa9f212fc4e63802290ef615 [diff] |
Fix tab support in Assistant settings
This is a temporary fix.
The real fix will be to move away from the Content Service and back to
|views::WebView|. This is tracked in b/146351046.
- Embedded UI:
- TAB and shift-TAB works for settings.
- TAB and shift-TAB works for webview based Assistant response
(to the query |weather|).
- Open Settings, click on other window, click back on settings,
verify TAB and shift-TAB still work.
- Standalone UI:
- TAB and shift-TAB works for settings.
- TAB and shift-TAB works for webview based Assistant response
(to the query |weather|).
Bug: 145213680
Change-Id: If0f39d4911409f177fb1f93525205ad7392bdd35
Tests: Manually tested that:
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979633
Reviewed-by: Xiaohui Chen <[email protected]>
Commit-Queue: Jeroen Dhollander <[email protected]>
Cr-Commit-Position: refs/heads/master@{#727225}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .