| commit | d743f5812fc9a602d3161353926a8c7281d7bdcd | [log] [tgz] |
|---|---|---|
| author | Noel Gordon <[email protected]> | Fri May 25 05:38:41 2018 |
| committer | Commit Bot <[email protected]> | Fri May 25 05:38:41 2018 |
| tree | 94927769987a986b2299bd833cf109a83fd2d73b | |
| parent | 605262388e13e31dfaaa017ed16ac316e2c4a2b0 [diff] |
FilesAppBrowserTest: code and document the use of trusted events Remove the concept of LegacyEvents: irrelevant. Instead change concept to the use of Trusted JS Events, which are used to force Blink to send Tab key events to the Files.App page under test (add a comment). If we don't use trusted Events, Blink consumes Tab key events with its default handlers and the Tab key never reaches the JS page under test. This affects the browser tests involving "tabindex" -- they won't work unless they receive Tab key JS Events [1]. Clean up the TestCase struct: remove the accessors, and access members directly since all access is const anyway. Add a new struct EventTest, to specialize TestCase for the few tests that need trusted Events. No change in behavior, no new tests. [1] see crbug.com/482121 crbug.com/480491 Bug: 836254,482121,480491 Change-Id: Ic1906c6033ccc65be43b2c8cbe1344e5ffec4655 Reviewed-on: https://chromium-review.googlesource.com/1072220 Reviewed-by: Stuart Langley <[email protected]> Reviewed-by: Naoki Fukino <[email protected]> Commit-Queue: Noel Gordon <[email protected]> Cr-Commit-Position: refs/heads/master@{#561777}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .