Google Git
Sign in
chromium / chromium / src / 8d2dce46ff10f87afde8b7a8359c4e695769e896
commit8d2dce46ff10f87afde8b7a8359c4e695769e896[log] [tgz]
authorMikel Astiz <[email protected]>Mon Jul 26 19:05:36 2021
committerChromium LUCI CQ <[email protected]>Mon Jul 26 19:05:36 2021
treed0ba04a1583eac6613560ce98ee6074cdf746a15
parent511d2dffbcb26d2c8fd721368c873bc73ff64d14 [diff]
[sync] Expose a bookmark's parent's GUID in sync protocol (specifics)

The field is somewhat redundant to the pre-existing parent_id proto
field, which is server-defined. The new field (a GUID in specifics)
has a number of advantages:
1) Is very simple, and in particular does not require fancy dealing with
   temporary IDs during commits.
2) Is more robust agaist hash collisions and server-side proto
   serialization bugs.
3) Is better privacy-wise, since it can be encrypted (for custom
   passphrase users).
4) Unblocks better dealing with orphan nodes, which would now at least
   determine the parent's GUID, and hence such a folder can in fact be
   created (with a proper GUID) without having any further information.

That said, none of the advantages listed above will be achieved for real
anytime soon, since old data will continue to exist for a long while.
Nevertheless, let's set the foundation for a better long-term future.

Change-Id: Icfe2530a679b519e54115a378d9a67a6e7f239d2
Bug: 1143246
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3053690
Reviewed-by: Scott Violet <[email protected]>
Reviewed-by: Rushan Suleymanov <[email protected]>
Commit-Queue: Mikel Astiz <[email protected]>
Cr-Commit-Position: refs/heads/master@{#905361}
11 files changed
tree: d0ba04a1583eac6613560ce98ee6074cdf746a15
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .mailmap
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.