Convert remaining StringToLowerASCII to ToLowerASCII.
Remove StringToLowerASCII. This removes the template and makes a consistent call that can take a string piece.
http_response_headers.cc in HttpResponseHeaders::RemoveHeaderLine there seemed to be a bug where it did
std::string old_header_name_lowercase(name);
where it actually meant
std::string old_header_name_lowercase(old_header_name);
I fixed this.
There were a number of cases where url.host() or url.scheme() was passed to ToLowerASCII. These are already guaranteed lower-case, so I removed the call.
There were a number of cases in net that did return ToLowerASCII().c_str() when the return type is a std::string, which is unnecessary and wasteful. I removed the c_str() call.
NOPRESUBMIT=true
(for touching code with wstrings)
Review URL: https://codereview.chromium.org/1282363003
Cr-Commit-Position: refs/heads/master@{#342869}
diff --git a/ui/gfx/font_unittest.cc b/ui/gfx/font_unittest.cc
index 4b81c81..102c7c8 100644
--- a/ui/gfx/font_unittest.cc
+++ b/ui/gfx/font_unittest.cc
@@ -58,8 +58,7 @@
EXPECT_EQ(cf.GetStyle(), Font::NORMAL);
EXPECT_EQ(cf.GetFontSize(), 16);
EXPECT_EQ(cf.GetFontName(), "Arial");
- EXPECT_EQ("arial",
- base::StringToLowerASCII(cf.GetActualFontNameForTesting()));
+ EXPECT_EQ("arial", base::ToLowerASCII(cf.GetActualFontNameForTesting()));
}
#if defined(OS_ANDROID)
@@ -74,8 +73,7 @@
EXPECT_TRUE(bold.GetNativeFont());
#endif
EXPECT_EQ(bold.GetStyle(), Font::BOLD);
- EXPECT_EQ("arial",
- base::StringToLowerASCII(cf.GetActualFontNameForTesting()));
+ EXPECT_EQ("arial", base::ToLowerASCII(cf.GetActualFontNameForTesting()));
}
#if defined(OS_ANDROID)
@@ -139,15 +137,13 @@
// http://crbug.com/347429
TEST_F(FontTest, MAYBE_GetActualFontNameForTesting) {
Font arial("Arial", 16);
- EXPECT_EQ("arial",
- base::StringToLowerASCII(arial.GetActualFontNameForTesting()))
+ EXPECT_EQ("arial", base::ToLowerASCII(arial.GetActualFontNameForTesting()))
<< "********\n"
<< "Your test environment seems to be missing Arial font, which is "
<< "needed for unittests. Check if Arial font is installed.\n"
<< "********";
Font symbol("Symbol", 16);
- EXPECT_EQ("symbol",
- base::StringToLowerASCII(symbol.GetActualFontNameForTesting()))
+ EXPECT_EQ("symbol", base::ToLowerASCII(symbol.GetActualFontNameForTesting()))
<< "********\n"
<< "Your test environment seems to be missing Symbol font, which is "
<< "needed for unittests. Check if Symbol font is installed.\n"
@@ -156,8 +152,7 @@
const char* const invalid_font_name = "no_such_font_name";
Font fallback_font(invalid_font_name, 16);
EXPECT_NE(invalid_font_name,
- base::StringToLowerASCII(
- fallback_font.GetActualFontNameForTesting()));
+ base::ToLowerASCII(fallback_font.GetActualFontNameForTesting()));
}
#if defined(OS_WIN)
