Reland "[base] Stop including check.h, notreached.h, etc. in logging.h"
This is a reland of f85481f892e03cd068e7f7543d76222c678b0bdb
Fixes since the previous commit:
https://chrome-internal-review.googlesource.com/c/chrome/deps/amd/+/3133484
https://chrome-internal-review.googlesource.com/c/chrome/assistant/+/3133487
https://chrome-internal-review.googlesource.com/c/chrome/assistant/+/3135083
https://chromium-review.googlesource.com/c/chromium/src/+/2264371
Original change's description:
> [base] Stop including check.h, notreached.h, etc. in logging.h
>
> The CHECK, CHECK_EQ etc., and NOTREACHED macros have moved out
> of logging.h into separate, much cheaper to include, headers.
>
> Now that the code has been updated to use the new headers, and
> to not rergess on that, stop including them in logging.h.
>
> Bug: 1031540
> Change-Id: Idfa891b991cbca1dfef93630c0f37b1b022f99df
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264413
> Reviewed-by: Nico Weber <[email protected]>
> Reviewed-by: Daniel Cheng <[email protected]>
> Auto-Submit: Hans Wennborg <[email protected]>
> Commit-Queue: Daniel Cheng <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#781970}
TBR=thakis
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: 1031540
Change-Id: Ie889e031d229745f93363c7bb2605c4f65591f60
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264297
Commit-Queue: Hans Wennborg <[email protected]>
Reviewed-by: Hans Wennborg <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Cr-Commit-Position: refs/heads/master@{#782682}
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index 1165972..faa592b 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -1620,7 +1620,7 @@
def _CheckDCHECK_IS_ONHasBraces(input_api, output_api):
"""Checks to make sure DCHECK_IS_ON() does not skip the parentheses."""
errors = []
- pattern = input_api.re.compile(r'DCHECK_IS_ON(?!\(\))',
+ pattern = input_api.re.compile(r'DCHECK_IS_ON\b(?!\(\))',
input_api.re.MULTILINE)
for f in input_api.AffectedSourceFiles(input_api.FilterSourceFile):
if (not f.LocalPath().endswith(('.cc', '.mm', '.h'))):
