Fix some "gn check" issues for chrome/browser/extensions
Separate out a separate target for command_ids.h. Currently this was just being added to random targets. This removes it from the gypi files since this causes it to be confusigly added to a bunch of gn targets. The only use of this is for GYP analyze when this one header changes, which shouldn't be necessary any more.
There are a few minor fixes to //chrome/browser, but most of the fixes are to //chrome/browser/extensions. This change fixes about half of the errors in that target.
Review-Url: https://codereview.chromium.org/2170193002
Cr-Commit-Position: refs/heads/master@{#407932}
diff --git a/chrome/browser/BUILD.gn b/chrome/browser/BUILD.gn
index 15d60541..3543834 100644
--- a/chrome/browser/BUILD.gn
+++ b/chrome/browser/BUILD.gn
@@ -459,6 +459,7 @@
}
if (enable_extensions) {
public_deps += [ "//chrome/browser/extensions" ]
+ allow_circular_includes_from += [ "//chrome/browser/extensions" ]
deps += [
"//chrome/browser/sync_file_system/drive_backend:sync_file_system_drive_proto",
"//chrome/common/extensions/api",
@@ -644,6 +645,7 @@
if (use_ash) {
sources +=
rebase_path(gypi_values.chrome_browser_ash_sources, ".", "//chrome")
+ deps += [ "//ash" ]
}
if (use_x11) {
