| commit | 99053450f5597641843d293b82cb895f2c690665 | [log] [tgz] |
|---|---|---|
| author | [email protected] <[email protected]@0039d316-1c4b-4281-b951-d872f2087c98> | Wed Sep 04 13:37:41 2013 |
| committer | [email protected] <[email protected]@0039d316-1c4b-4281-b951-d872f2087c98> | Wed Sep 04 13:37:41 2013 |
| tree | 18ddb439eaa4bb71fec703ea0a72ad11baff6da0 | |
| parent | 578f35f9004eb03dc2088e85cc6ab75f4f14277f [diff] [blame] |
Re-land https://codereview.chromium.org/23602005: Use nobarrier atomics for lossy counters in base::HistogramSamples and base::SampleVector This should not affect the performance, but will make it explicit that the counter values are expected to be read and written atomically. This will also suppress the ThreadSanitizer v2 reports on these counters. BUG=46840 [email protected] Review URL: https://codereview.chromium.org/23450016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221183 0039d316-1c4b-4281-b951-d872f2087c98
diff --git a/base/metrics/histogram_base.h b/base/metrics/histogram_base.h index f5448e7..4663647 100644 --- a/base/metrics/histogram_base.h +++ b/base/metrics/histogram_base.h
@@ -7,6 +7,7 @@ #include <string> +#include "base/atomicops.h" #include "base/base_export.h" #include "base/basictypes.h" #include "base/memory/scoped_ptr.h" @@ -50,8 +51,8 @@ class BASE_EXPORT HistogramBase { public: - typedef int Sample; // Used for samples. - typedef int Count; // Used to count samples. + typedef int Sample; // Used for samples. + typedef subtle::Atomic32 Count; // Used to count samples. static const Sample kSampleType_MAX; // INT_MAX