Adapt, build, and test old Rust Mojo bindings
Continues work started in
https://chromium-review.googlesource.com/c/chromium/src/+/3233000 to
revive Rust mojo bindings used in previous standalone Mojo SDK.
These bindings are outdated. They referred to several Mojo core API
functions that no longer exist (e.g. wait sets), several other
functions now have different signatures, and the mojom encoding and
decoding does not match current Mojo among other things. Further,
these bindings have their own run loop implementation (based on
outdated wait sets). Integrating with current Mojo will require
significant changes:
* Updating the system bindings to closely match the C API
* Adding code gen support for mojom bindings
* Integrating mojom bindings with Chrome's run loop
As a proof-of-concept this CL adds the bindings and tests to the
build. Many of the tests succeed demonstrating the viability of
reviving these Rust bindings. The ones that fail are due to changes in
the API. The following changes were necessary to build and test
successfully:
* Fixed various 2018 edition build issues
* Added replacements for missing Mojo C API functions
* Updated several function signatures
Bug: 1274864
Change-Id: Ie3101e31d28a75f23cafd3a66e7fdf09b6ca2809
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3282310
Reviewed-by: Nico Weber <[email protected]>
Auto-Submit: Collin Baker <[email protected]>
Reviewed-by: Robert Sesek <[email protected]>
Commit-Queue: Robert Sesek <[email protected]>
Cr-Commit-Position: refs/heads/main@{#963667}
diff --git a/BUILD.gn b/BUILD.gn
index 7b9ea40..8ddb4792d 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -12,6 +12,7 @@
import("//build/config/compiler/compiler.gni")
import("//build/config/dcheck_always_on.gni")
import("//build/config/features.gni")
+import("//build/config/rust.gni")
import("//build/config/sanitizers/sanitizers.gni")
import("//build/config/ui.gni")
import("//build/gn_logs.gni")
@@ -853,6 +854,14 @@
# Minimal binaries to exercise Rust toolchain.
deps += [ ":rust_build_tests" ]
+
+ # More Rust targets.
+ if (toolchain_has_rust) {
+ deps += [
+ "//mojo/public/rust",
+ "//mojo/public/rust:tests",
+ ]
+ }
}
group("rust_build_tests") {
