| commit | a43d5b4e2a84f49d1c25029ddeeaa33484b11ebb | [log] [tgz] |
|---|---|---|
| author | Roman Karasev <[email protected]> | Thu Dec 21 03:06:02 2017 |
| committer | Commit Bot <[email protected]> | Thu Dec 21 18:55:12 2017 |
| tree | 7c6e4fd6d63f3c06c74772e8d364195ddaedc54b | |
| parent | 2540c9393da72a68402841bb9c6aafa175da7d6d [diff] [blame] |
ACCESS_VIOLATION exception When IPC::Message is constructed from empty data, it has invalid state. Attempt to access its header (e.g. calling type() method) leads to ACCESS_VIOLATION exception because header_ is nullptr at this time. Change-Id: Id58df83d49d4de5f3d459c600abdecc76da36ecc Bug: 793749 Change-Id: Id58df83d49d4de5f3d459c600abdecc76da36ecc Reviewed-on: https://chromium-review.googlesource.com/800076 Commit-Queue: danakj <[email protected]> Reviewed-by: John Abd-El-Malek <[email protected]> Reviewed-by: danakj <[email protected]> Reviewed-by: Ken Rockot <[email protected]> Reviewed-by: Tom Sepez <[email protected]> Cr-Commit-Position: refs/heads/master@{#525754}
diff --git a/base/pickle.h b/base/pickle.h index 4fe98d4..eff2092 100644 --- a/base/pickle.h +++ b/base/pickle.h
@@ -263,6 +263,10 @@ } protected: + // Returns size of the header, which can have default value, set by user or + // calculated by passed raw data. + size_t header_size() const { return header_size_; } + char* mutable_payload() { return reinterpret_cast<char*>(header_) + header_size_; }