Create base test class and test rule to set color overlay.
This allows tests that need a valid dummy activity to have the correct
base themes. This is done by creating a new test rule that will set the
static test theme field on the DummyUiActivity before creation, and then
by switching the base test class to one that uses the new rule. All
tests in //chrome/* were migrated to this, as this will be essentially
mandatory as most colors will shortly be switched to attributes.
Most changes here are mechanical, created by running the commands:
> find chrome/ -type f -name "*.java" | xargs -n1 sed -i \
"s/import org.chromium.ui.test.util.DummyUiActivityTestCase/import org.chromium.chrome.test.DummyUiChromeActivityTestCase/g"
> find chrome/ -type f -name "*.java" | xargs -n1 sed -i \
"s/extends DummyUiActivityTestCase/extends DummyUiChromeActivityTestCase/g"
Direct usage of the rule BaseActivityTestRule<DummyUiActivity> was then
updated by hand to use ThemedDummyUiActivityTestRule with
R.style.ColorOverlay.
The interesting changes live in
* ui/android/javatests/src/org/chromium/ui/test/util/ThemedDummyUiActivityTestRule.java
* chrome/test/android/javatests/src/org/chromium/chrome/test/DummyUiChromeActivityTestCase.java
* ui/android/javatests/src/org/chromium/ui/test/util/DummyUiActivityTestCase.java
Bug: 1227875
Change-Id: I7034cb401406962b0ff938ecb086de22da06c884
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3021741
Commit-Queue: Sky Malice <[email protected]>
Reviewed-by: Wenyu Fu <[email protected]>
Reviewed-by: Theresa <[email protected]>
Reviewed-by: Sinan Sahin <[email protected]>
Cr-Commit-Position: refs/heads/master@{#901131}
diff --git a/chrome/browser/settings/BUILD.gn b/chrome/browser/settings/BUILD.gn
index bc94f4d..e4f6410 100644
--- a/chrome/browser/settings/BUILD.gn
+++ b/chrome/browser/settings/BUILD.gn
@@ -43,6 +43,7 @@
"//third_party/androidx:androidx_test_runner_java",
"//third_party/hamcrest:hamcrest_java",
"//third_party/junit",
+ "//ui/android:ui_java_test_support",
]
}
