Remove some legacy versions of StartsWith and EndsWith.
This just replaces
true -> base::CompareCase::SENSITIVE
false -> base::CompareCase::INSENSITIVE_ASCII
I checked the insensitive cases to make sure they're not doing anything suspicious. The old version is a sometimes-correct Unicode comparison so converting to INSENSTITIVE_ASCII isn't a no-op. However, generally the prefix/suffix checking is done against a hardcoded string so there were very few cases to actually look at.
extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.cc has a not-quite search-and-replace change where I changed the type of a class variable.
BUG=506255
TBR=jam
Reland of http://crrev.com/1239493005
Review URL: https://codereview.chromium.org/1233043003
Cr-Commit-Position: refs/heads/master@{#339071}
diff --git a/chrome/browser/extensions/default_apps.cc b/chrome/browser/extensions/default_apps.cc
index c8078e4..2cc3228 100644
--- a/chrome/browser/extensions/default_apps.cc
+++ b/chrome/browser/extensions/default_apps.cc
@@ -37,7 +37,8 @@
const std::string& locale = g_browser_process->GetApplicationLocale();
static const char* const unsupported_locales[] = {"CN", "TR", "IR"};
for (size_t i = 0; i < arraysize(unsupported_locales); ++i) {
- if (base::EndsWith(locale, unsupported_locales[i], false)) {
+ if (base::EndsWith(locale, unsupported_locales[i],
+ base::CompareCase::INSENSITIVE_ASCII)) {
return false;
}
}
