| commit | a8009f8f719dfdf6af6d056471449ca43fa52fe0 | [log] [tgz] |
|---|---|---|
| author | Yoshifumi Inoue <[email protected]> | Fri Apr 16 08:05:17 2021 |
| committer | Chromium LUCI CQ <[email protected]> | Fri Apr 16 08:05:17 2021 |
| tree | b8ab0bb2e1292afca1debceef4e68bfe6dfc93f7 | |
| parent | 33c71d28980bf90ee70e691d7dd824c023226475 [diff] |
Paints caret in multicol correctly
This patch makes painting caret in multi-column correctly by checking
whether painting caret by |NGPhysicalBoxFragment| instead of
|LayoutBlock|.
Caret painting and paint invalidation are done as below:
1. |CaretDisplayItemClient| computes |LocalCaretRect| from caret DOM
position. |LocalCaretRect| holds layout object containing caret,
caret rect inside layout object, box fragment containing caret rect.
2. Box fragment painter asks |CaretDisplayItemClient| to paint caret in
the box fragment.
3. |CaretDisplayItemClient| paints caret if asked box fragment equals to
holding box fragment.
Before this patch, we use |LayoutBlock| instead of |NGPhysicalBoxFragment|,
so we paint caret multiple times == number of columns.
After this patch, we paint caret once for |NGPhysicalBoxFragment| where
caret rect is in.
Note: This patch works only for multicol container has block level
children == |LayoutMultiColumnFlowThread| is block level container.
The CL[1] will make |LayoutMultiColumnFlowThread| to have block level
children only.
[1] http://crrev.com/c/2823033 Make LayoutMulticolFlowThread to have block
level children only
Bug: 829028
Change-Id: I752e9f60d2075449d2ce293230ca33c405de39f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2820193
Reviewed-by: Koji Ishii <[email protected]>
Commit-Queue: Koji Ishii <[email protected]>
Auto-Submit: Yoshifumi Inoue <[email protected]>
Cr-Commit-Position: refs/heads/master@{#873231}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.