Google Git
Sign in
chromium / chromium / src / f198b80257f1aae692904ef0b3785b7f7cadceff
commitf198b80257f1aae692904ef0b3785b7f7cadceff[log] [tgz]
authorToni Barzic <[email protected]>Wed Sep 04 23:08:17 2019
committerCommit Bot <[email protected]>Wed Sep 04 23:08:17 2019
tree8d988bbd00e5d3e62a279b71265de3d656e271dd
parent9371a7201413470ab03352fddaee8e682024901d [diff]
Extract AppListConfig creation into separate class

Move app list config creation from AppListConfig::instance to a
newly introduced class AppListConfigProvider.
Having a dedicated "factory" class for AppListConfig instances is
cleaner than creating new configs off of a global AppListConfig
instance.

In addition to CreateAppListConfigForAppListWidget (which was moved from
AppListConfig::instance), adds getter for app list configs per
AppListConfigType, which will be used in a later cl to provide apps grid
configuration to app list model (needed to generate folder image for app
list config type).

Adds some test for AppListConfigs, and fixes the app list item title
margins and fonts.

BUG=998207,996808

Change-Id: Id6c395d1087cbc17982ce7a9e263e1dbbdc7752d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783518
Commit-Queue: Toni Baržić <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Reviewed-by: Alex Newcomer <[email protected]>
Cr-Commit-Position: refs/heads/master@{#693421}
7 files changed
tree: 8d988bbd00e5d3e62a279b71265de3d656e271dd
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .