Reland "Remove unsupported perm, symlink calls for Fuchsia."
Reland "Remove unsupported perm, symlink calls for Fuchsia."
The previous CL was landed at the same time as net_unittests,
which depended on calls that were conditionally removed from this CL.
This CL adds !OS_FUCHSIA guards to the relevant ifdef blocks in
url_request_unittest and sql/connection.cc.
Removing these functions from Fuchsia builds will make it easier to
detect and prevent any future regressions, since they'll appear as
build breakages.
R: [email protected]
Bug: 706592
Change-Id: Iad6343a3cb6fcc90b742de04bb8052e77ba498c7
Reviewed-on: https://chromium-review.googlesource.com/569845
Commit-Queue: Kevin Marshall <[email protected]>
Reviewed-by: Victor Costan <[email protected]>
Reviewed-by: David Benjamin <[email protected]>
Reviewed-by: Nico Weber <[email protected]>
Cr-Commit-Position: refs/heads/master@{#486632}diff --git a/sql/connection.cc b/sql/connection.cc
index c80758f..d7477f57 100644
--- a/sql/connection.cc
+++ b/sql/connection.cc
@@ -31,6 +31,7 @@
#include "base/synchronization/lock.h"
#include "base/threading/thread_task_runner_handle.h"
#include "base/trace_event/memory_dump_manager.h"
+#include "build/build_config.h"
#include "sql/connection_memory_dump_provider.h"
#include "sql/meta_table.h"
#include "sql/statement.h"
@@ -1726,7 +1727,7 @@
}
// TODO(shess): OS_WIN support?
-#if defined(OS_POSIX)
+#if defined(OS_POSIX) && !defined(OS_FUCHSIA)
if (restrict_to_user_) {
DCHECK_NE(file_name, std::string(":memory"));
base::FilePath file_path(file_name);
@@ -1747,7 +1748,7 @@
base::SetPosixFilePermissions(wal_path, mode);
}
}
-#endif // defined(OS_POSIX)
+#endif // defined(OS_POSIX) && !defined(OS_FUCHSIA)
// SQLite uses a lookaside buffer to improve performance of small mallocs.
// Chromium already depends on small mallocs being efficient, so we disable
