net: Add out-of-line copy ctors for complex classes.
This patch adds out of line copy constructors for classes that our
clang-plugin considers heavy. This is an effort to enable copy
constructor checks by default.
BUG=436357
[email protected], [email protected], [email protected]
Review URL: https://codereview.chromium.org/1728333003
Cr-Commit-Position: refs/heads/master@{#377976}
diff --git a/net/websockets/websocket_channel.cc b/net/websockets/websocket_channel.cc
index 3018088d..7d166ee 100644
--- a/net/websockets/websocket_channel.cc
+++ b/net/websockets/websocket_channel.cc
@@ -286,6 +286,9 @@
offset_(offset),
size_(size) {}
+WebSocketChannel::PendingReceivedFrame::PendingReceivedFrame(
+ const PendingReceivedFrame& other) = default;
+
WebSocketChannel::PendingReceivedFrame::~PendingReceivedFrame() {}
void WebSocketChannel::PendingReceivedFrame::ResetOpcode() {
diff --git a/net/websockets/websocket_channel.h b/net/websockets/websocket_channel.h
index 7f341950..97db65f 100644
--- a/net/websockets/websocket_channel.h
+++ b/net/websockets/websocket_channel.h
@@ -149,6 +149,7 @@
const scoped_refptr<IOBuffer>& data,
uint64_t offset,
uint64_t size);
+ PendingReceivedFrame(const PendingReceivedFrame& other);
~PendingReceivedFrame();
bool final() const { return final_; }
diff --git a/net/websockets/websocket_extension.cc b/net/websockets/websocket_extension.cc
index c5e8e17..a0d55607 100644
--- a/net/websockets/websocket_extension.cc
+++ b/net/websockets/websocket_extension.cc
@@ -32,6 +32,9 @@
WebSocketExtension::WebSocketExtension(const std::string& name)
: name_(name) {}
+WebSocketExtension::WebSocketExtension(const WebSocketExtension& other) =
+ default;
+
WebSocketExtension::~WebSocketExtension() {}
bool WebSocketExtension::Equals(const WebSocketExtension& other) const {
diff --git a/net/websockets/websocket_extension.h b/net/websockets/websocket_extension.h
index 20f2922..4c42a76 100644
--- a/net/websockets/websocket_extension.h
+++ b/net/websockets/websocket_extension.h
@@ -38,6 +38,7 @@
WebSocketExtension();
explicit WebSocketExtension(const std::string& name);
+ WebSocketExtension(const WebSocketExtension& other);
~WebSocketExtension();
void Add(const Parameter& parameter) { parameters_.push_back(parameter); }
