Add StringPiece getters for GURL, minor cleanup.
This adds *_piece() getters for each URL component which avoids intermediate string copies.
Does some extra commenting and cleanup in gurl.h with new comments. The getters and test functions for each component type are now grouped. I removed references to future additions to encoding parameters which we will never do at this point. This also removes an unnecessary lower-casing step in GURL::SchemeIs since things are known lowercase, so scheme comparisons should be faster.
I did a quick grep for obvious cases of some of the getters that can be replaced with the *_piece versions and updated them. In net_util there is an additional cleanup where a more complicated test could be replaced with EndsWith.
Review URL: https://codereview.chromium.org/1360863003
Cr-Commit-Position: refs/heads/master@{#350733}
diff --git a/chrome/browser/extensions/extension_tab_util.cc b/chrome/browser/extensions/extension_tab_util.cc
index 2e85087..d6bba33 100644
--- a/chrome/browser/extensions/extension_tab_util.cc
+++ b/chrome/browser/extensions/extension_tab_util.cc
@@ -576,8 +576,9 @@
if (!fixed_url.SchemeIs(content::kChromeUIScheme))
return false;
+ base::StringPiece fixed_host = fixed_url.host_piece();
for (size_t i = 0; i < arraysize(kill_hosts); ++i) {
- if (fixed_url.host() == kill_hosts[i])
+ if (fixed_host == kill_hosts[i])
return true;
}
