Move extension notifications to extensions/browser/notification_types.h

As part of the extensions module refactor we temporarily allowed the use
of chrome_notification_types.h in src/extensions. However, this allowed
code moving into src/extensions to listen to notifications from Chrome,
which was a layering violation.

This CL moves all the extensions notifications into their own header and
cleans up DEPS to disallow the exception.

BUG=392622
TEST=compiles, unit_tests, browser_tests, extensions_unittests
[email protected] for apps/

Review URL: https://codereview.chromium.org/425303002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@286770 0039d316-1c4b-4281-b951-d872f2087c98
diff --git a/chrome/browser/extensions/install_tracker.cc b/chrome/browser/extensions/install_tracker.cc
index ffa52fa..b3a272f 100644
--- a/chrome/browser/extensions/install_tracker.cc
+++ b/chrome/browser/extensions/install_tracker.cc
@@ -18,7 +18,7 @@
                                extensions::ExtensionPrefs* prefs)
     : extension_registry_observer_(this) {
   registrar_.Add(this,
-                 chrome::NOTIFICATION_EXTENSION_UPDATE_DISABLED,
+                 extensions::NOTIFICATION_EXTENSION_UPDATE_DISABLED,
                  content::Source<content::BrowserContext>(browser_context));
   registrar_.Add(this,
                  chrome::NOTIFICATION_APP_INSTALLED_TO_APPLIST,
@@ -29,7 +29,7 @@
   if (prefs) {
     AppSorting* sorting = prefs->app_sorting();
     registrar_.Add(this,
-                   chrome::NOTIFICATION_EXTENSION_LAUNCHER_REORDERED,
+                   chrome::NOTIFICATION_APP_LAUNCHER_REORDERED,
                    content::Source<AppSorting>(sorting));
     pref_change_registrar_.Init(prefs->pref_service());
     pref_change_registrar_.Add(
@@ -135,14 +135,14 @@
                              const content::NotificationSource& source,
                              const content::NotificationDetails& details) {
   switch (type) {
-    case chrome::NOTIFICATION_EXTENSION_UPDATE_DISABLED: {
+    case extensions::NOTIFICATION_EXTENSION_UPDATE_DISABLED: {
       const Extension* extension =
           content::Details<const Extension>(details).ptr();
       FOR_EACH_OBSERVER(
           InstallObserver, observers_, OnDisabledExtensionUpdated(extension));
       break;
     }
-    case chrome::NOTIFICATION_EXTENSION_LAUNCHER_REORDERED: {
+    case chrome::NOTIFICATION_APP_LAUNCHER_REORDERED: {
       FOR_EACH_OBSERVER(InstallObserver, observers_, OnAppsReordered());
       break;
     }