Standardize usage of virtual/override/final in chrome/browser/extensions/
This patch was automatically generated by applying clang fixit hints
generated by the plugin to the source tree.
BUG=417463
[email protected]
Review URL: https://codereview.chromium.org/666153002
Cr-Commit-Position: refs/heads/master@{#300474}
diff --git a/chrome/browser/extensions/external_install_error.cc b/chrome/browser/extensions/external_install_error.cc
index 4b847b1..73ce2e8 100644
--- a/chrome/browser/extensions/external_install_error.cc
+++ b/chrome/browser/extensions/external_install_error.cc
@@ -51,19 +51,19 @@
class ExternalInstallMenuAlert : public GlobalError {
public:
explicit ExternalInstallMenuAlert(ExternalInstallError* error);
- virtual ~ExternalInstallMenuAlert();
+ ~ExternalInstallMenuAlert() override;
private:
// GlobalError implementation.
- virtual Severity GetSeverity() override;
- virtual bool HasMenuItem() override;
- virtual int MenuItemCommandID() override;
- virtual base::string16 MenuItemLabel() override;
- virtual void ExecuteMenuItem(Browser* browser) override;
- virtual bool HasBubbleView() override;
- virtual bool HasShownBubbleView() override;
- virtual void ShowBubbleView(Browser* browser) override;
- virtual GlobalErrorBubbleViewBase* GetBubbleView() override;
+ Severity GetSeverity() override;
+ bool HasMenuItem() override;
+ int MenuItemCommandID() override;
+ base::string16 MenuItemLabel() override;
+ void ExecuteMenuItem(Browser* browser) override;
+ bool HasBubbleView() override;
+ bool HasShownBubbleView() override;
+ void ShowBubbleView(Browser* browser) override;
+ GlobalErrorBubbleViewBase* GetBubbleView() override;
// The owning ExternalInstallError.
ExternalInstallError* error_;
@@ -76,25 +76,25 @@
public:
explicit ExternalInstallBubbleAlert(ExternalInstallError* error,
ExtensionInstallPrompt::Prompt* prompt);
- virtual ~ExternalInstallBubbleAlert();
+ ~ExternalInstallBubbleAlert() override;
private:
// GlobalError implementation.
- virtual Severity GetSeverity() override;
- virtual bool HasMenuItem() override;
- virtual int MenuItemCommandID() override;
- virtual base::string16 MenuItemLabel() override;
- virtual void ExecuteMenuItem(Browser* browser) override;
+ Severity GetSeverity() override;
+ bool HasMenuItem() override;
+ int MenuItemCommandID() override;
+ base::string16 MenuItemLabel() override;
+ void ExecuteMenuItem(Browser* browser) override;
// GlobalErrorWithStandardBubble implementation.
- virtual gfx::Image GetBubbleViewIcon() override;
- virtual base::string16 GetBubbleViewTitle() override;
- virtual std::vector<base::string16> GetBubbleViewMessages() override;
- virtual base::string16 GetBubbleViewAcceptButtonLabel() override;
- virtual base::string16 GetBubbleViewCancelButtonLabel() override;
- virtual void OnBubbleViewDidClose(Browser* browser) override;
- virtual void BubbleViewAcceptButtonPressed(Browser* browser) override;
- virtual void BubbleViewCancelButtonPressed(Browser* browser) override;
+ gfx::Image GetBubbleViewIcon() override;
+ base::string16 GetBubbleViewTitle() override;
+ std::vector<base::string16> GetBubbleViewMessages() override;
+ base::string16 GetBubbleViewAcceptButtonLabel() override;
+ base::string16 GetBubbleViewCancelButtonLabel() override;
+ void OnBubbleViewDidClose(Browser* browser) override;
+ void BubbleViewAcceptButtonPressed(Browser* browser) override;
+ void BubbleViewCancelButtonPressed(Browser* browser) override;
// The owning ExternalInstallError.
ExternalInstallError* error_;