Google Git
Sign in
chromium / chromium / src / b6c64fcea90081413968dc205078c2df59f57653
commitb6c64fcea90081413968dc205078c2df59f57653[log] [tgz]
authorColin Blundell <[email protected]>Tue Jun 30 07:42:07 2020
committerCommit Bot <[email protected]>Tue Jun 30 07:42:07 2020
tree47fa0f9a82bf356abb39323102f98a657b5d5e6e
parent96034ad870d95660ffc0b07f5662624a08935b85 [diff]
[Infobars] Prepare Android's C++ ConfirmInfobar for componentization

In preparation for componentization of this class for sharing with
WebLayer, this CL cleans it of //chrome dependencies. We do so by
introducing a simple ChromeConfirmInfoBar convenience subclass that
glues ConfirmInfobar to //chrome, which will then enable ConfirmInfobar
itself to be componentized and reused by WebLayer. Note that any
//chrome-level subclasses of ChromeConfirmInfoBar could still easily
be componentized if desired in the future by simply changing them to
subclass from ConfirmInfoBar directly and take in the needed additional
parameters in *their* constructors for supplying by the embedder.

Bug: 1099169
Change-Id: I20b57b37eec57ed9932c6a3610f64e3860ac2900
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2272323
Commit-Queue: Colin Blundell <[email protected]>
Reviewed-by: Matthew Jones <[email protected]>
Cr-Commit-Position: refs/heads/master@{#783855}
33 files changed
tree: 47fa0f9a82bf356abb39323102f98a657b5d5e6e
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. ENG_REVIEW_OWNERS
  68. LICENSE
  69. LICENSE.chromium_os
  70. OWNERS
  71. PRESUBMIT.py
  72. PRESUBMIT_test.py
  73. PRESUBMIT_test_mocks.py
  74. README.md
  75. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.