| commit | bfd0b6e16b1a761333891b69a8ba9df222877198 | [log] [tgz] |
|---|---|---|
| author | Dirk Pranke <[email protected]> | Tue Jun 16 23:09:53 2020 |
| committer | Commit Bot <[email protected]> | Tue Jun 16 23:09:53 2020 |
| tree | f09f07a5ec31e67b26330be0414946931630dd66 | |
| parent | e8060c10aafd9a359684a799eed681764397c936 [diff] [blame] |
Update contributing doc to clarify how big new things get added.
The //docs/contributing.md file talks about how all code in
Chromium must be relevant to the project, but as written it was
somewhat circular ("should be in service of other code"); this
CL updates the wording a bit to try and clarify how completely new
top-level things (like //fuchsia) get approved.
[email protected], [email protected], [email protected]
Change-Id: I35246fff40d3cec0700e55d904f63973db2eaee0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246830
Reviewed-by: Darin Fisher <[email protected]>
Reviewed-by: Kentaro Hara <[email protected]>
Reviewed-by: Jochen Eisinger <[email protected]>
Commit-Queue: Dirk Pranke <[email protected]>
Cr-Commit-Position: refs/heads/master@{#779061}
diff --git a/docs/contributing.md b/docs/contributing.md index bbaaacd3..753586f 100644 --- a/docs/contributing.md +++ b/docs/contributing.md
@@ -327,6 +327,10 @@ find a product in the Chromium repositories that depends on that line of code or else the line of code should be removed. + Completely new additions to the project (for example, support for a new OS + or architecture, or a new top-level directory for a new sub-project) must + be approved by [//ENG_REVIEW_OWNERS](../ENG_REVIEW_OWNERS). + - **Code should only be moved to a central location (e.g., //base) when multiple consumers would benefit.** We should resist the temptation to build overly generic common libraries as that can lead to code bloat and