Google Git
Sign in
chromium / chromium / src / c337a152ebdbecb7ae2fe7e1736c1ae2d83a2598
commitc337a152ebdbecb7ae2fe7e1736c1ae2d83a2598[log] [tgz]
authorSimeon Anfinrud <[email protected]>Mon Jan 23 22:15:16 2023
committerChromium LUCI CQ <[email protected]>Mon Jan 23 22:15:16 2023
treecf11770a500d5988d14d3ca2945021a1c43b0e58
parent7451569356653bc1edc50bece1fa49fe42273d45 [diff]
[Chromecast] Do not acquire audio focus when media is blocked.

This restores the 'is_remote_control_mode' variable that was
renamed in crrev.com/c/4150205, but moves the point at
which it decides whether to request audio focus to the native
CastContentWindowAndroid class.

The prior patch was insufficient because the media block state
was not initialized in the application's constructor, so the
decision to acquire audio focus needs to be delayed after
constructing the CastWebView until the actual UI needs to be
started.

CastContentWindowAndroid will tell CastWebContentsComponent to
request audio focus only if the app is not in remote control
mode and media starting is unblocked. To allow CCWA to know
whether media starting is blocked, this patch adds an accessor
to CastWebContents to obtain the MediaBlocker.

Bug: b/265833890
Test: cast_shell_junit_tests
Change-Id: I79c12a8784fae16790cf843de7ae62146066518f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4179546
Auto-Submit: Simeon Anfinrud <[email protected]>
Reviewed-by: Matthew Denton <[email protected]>
Commit-Queue: Sean Topping <[email protected]>
Reviewed-by: Sean Topping <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1095853}
10 files changed
tree: cf11770a500d5988d14d3ca2945021a1c43b0e58
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.