| commit | c49712937ee29c425b9bf6ba086f340432911d33 | [log] [tgz] |
|---|---|---|
| author | Hector Carmona <[email protected]> | Mon Oct 28 20:58:50 2019 |
| committer | Commit Bot <[email protected]> | Mon Oct 28 20:58:50 2019 |
| tree | bb6a1bc87549b57fd5ecbf313edf28db2c53b286 | |
| parent | 24ac5100465acf4f746ddfe192cb3b37e608dfbf [diff] [blame] |
A11y: Add application role and move focus in cr-action-menu. Adding role="application" lets us be in control of the mode change on windows for screen readers. aria-roledescription is necessary now because we don't want to change users' expectations that this is a menu. Focus target change is necessary because focusing the application causes all its contents to be read as a label. Bug: 855123 Change-Id: If2428d875f325b55339b6ad3c14874c9e066e584 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869483 Reviewed-by: Colin Blundell <[email protected]> Reviewed-by: Dan Beam <[email protected]> Commit-Queue: Hector Carmona <[email protected]> Cr-Commit-Position: refs/heads/master@{#710034}
diff --git a/components/components_strings.grd b/components/components_strings.grd index e7afc91..68e303e 100644 --- a/components/components_strings.grd +++ b/components/components_strings.grd
@@ -260,6 +260,9 @@ <message name="IDS_SAVE" desc="Used on a button to save information you are editing."> Save </message> + <message name="IDS_MENU" desc="The accessible name for the Menu. This is used as the aria-roledescription for context menus."> + Menu + </message> <if expr="is_android"> <message name="IDS_SHOW" desc="Generic label to show content for a feature. [CHAR-LIMIT=20]" formatter_data="android_java"> Show