tree 3883d0d629f3ca77a8b31d361507636517698d21
parent 7fc7b1beb91d1c5dbb6b017e02553d898d504e83
author danakj <danakj@chromium.org> 1657208899 +0000
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> 1657208899 +0000

Replace raw_ptr with raw_ref in DocumentService

This also changes the subclasses of DocumentService to work with
references to RenderFrameHost, since DocumentService no longer vends
a pointer.

While doing so, any public constructor or destructor in a
DocumentService subclass was made private. CreateForTesting() was
added where needed.

CHECK() is added if not present (or converted from DCHECK()) when
turning RenderFrameHost* into RenderFrameHost&.

There are, of course, more pointers that could become references, but
this CL has to stop somewhere.

R=dcheng@chromium.org

Bug: 1339061, 1252046
Change-Id: I00033bcbabd9c4d268b0f5745b12031928dbf914
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3721411
Owners-Override: Alexander Timin <altimin@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Alexander Timin <altimin@chromium.org>
Auto-Submit: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1021695}