Remove forced _HAS_TR1=0 define. VS2010 headers unconditionally define _HAS_TR1=1. The gyp msvs 2010 generator has a hardcoded hack to remove _HAS_TR1=0 from the defines, but it seems better not to add this to the ninja generator too.
Added here http://codereview.chromium.org/147015/ but not sure of reason. Perhaps the define could just be removed now?
Review URL: https://chromiumcodereview.appspot.com/9865029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129310 0039d316-1c4b-4281-b951-d872f2087c98
diff --git a/build/common.gypi b/build/common.gypi
index 72dae4e8..f091100 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -2673,7 +2673,6 @@
'CERT_CHAIN_PARA_HAS_EXTRA_FIELDS',
'WIN32_LEAN_AND_MEAN',
'_ATL_NO_OPENGL',
- '_HAS_TR1=0',
],
'conditions': [
['buildtype=="Official"', {
@@ -2732,6 +2731,11 @@
'_HAS_EXCEPTIONS=0',
],
}],
+ ['MSVS_VERSION=="2008"', {
+ 'defines': [
+ '_HAS_TR1=0',
+ ],
+ }],
['secure_atl', {
'defines': [
'_SECURE_ATL',
