cc: Rename VSync to BeginFrame
We are replacing hard vsync scheduling with BeginFrame+deadline
intervals.
This patch removes references to vsync in CC where it will no
longer make sense. (One exception is cc::VSyncTimeSource, which
will be removed in future patches to be incorporated into the
scheduler itself.)
Additionally, BeginFrames are clarified with suffixes whenever
context is not enough and existing identifiers associated with
BeginFrame when it no longer makes sense are renamed.
A summary of the important renames are as follows:
Browser Side Renames:
COutputSurface::EnableVSyncNotification -> SetNeedsBeginFrame
COutputSurface::OnDidVSync -> OnBeginFrame
ViewHostMsg_SetVSyncNotificationEnabled -> ViewHostMsg_SetNeedsBeginFrame
ViewMsg_DidVSync -> ViewMsg_BeginFrame
Impl Side Renames:
LTHI::EnableVSyncNotification -> SetNeedsBeginFrame
LTHI::DidVSync -> BeginFrame
LTHI::DidRecieveLastInputEventForVSync -> DidReceiveLastInputEventForBeginFrame
Main+Impl Side Renames:
LTHIClient::DidVSync -> BeginFrameOnImplThread
LTHIClient::DidRecieveLastInputEventForVSync -> DidReceiveLastInputEventForBeginFrameOnImplThread
TProxy::BeginFrame -> BeginFrameOnMainThread
TProxy::ForceBeginFrameOnImplThread -> ForceCommitOnImplThread
TProxy::BeginFrameCompleteOnImplThread -> StartCommitOnImplThread
Scheduler::BeginFrameComplete -> FinishCommit
Scheduler::BeginFrameAborted -> BeginFrameAbortedByMainThread
Scheduler::LastVsyncTime -> LastBeginFrameOnImplThreadTime
Scheduler::VSyncTick -> BeginFrame
SchedulerSM::VSyncCallbackNeeded -> BeginFrameNeededByImplThread
SchedulerSM::ACTION_BEGIN_FRAME -> ACTION_SEND_BEGIN_FRAME_TO_MAIN_THREAD
FRC::DidBeginFrame -> DidSwapBuffers
FRC::DidFinishFrame -> DidSwapBuffersComplete
Random Renames:
LTSettings::render_vsync_enabled -> throttle_frame_production
LTSettings::render_vsync_notification_enabled -> render_parent_drives_begin_frame
LTSettings::synchronously_disable_vsync -> using_synchronous_renderer_compositor
RenderWidget::SynchronouslyDisableVSync -> UsingSynchronousRendererCompositor
BUG=240945
Review URL: https://chromiumcodereview.appspot.com/15058004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201739 0039d316-1c4b-4281-b951-d872f2087c98
diff --git a/cc/trees/layer_tree_host_impl.h b/cc/trees/layer_tree_host_impl.h
index 379349b0..57221b2f 100644
--- a/cc/trees/layer_tree_host_impl.h
+++ b/cc/trees/layer_tree_host_impl.h
@@ -54,7 +54,7 @@
virtual void OnSwapBuffersCompleteOnImplThread() = 0;
virtual void OnVSyncParametersChanged(base::TimeTicks timebase,
base::TimeDelta interval) = 0;
- virtual void DidVSync(base::TimeTicks frame_time) = 0;
+ virtual void BeginFrameOnImplThread(base::TimeTicks frame_time) = 0;
virtual void OnCanDrawStateChanged(bool can_draw) = 0;
virtual void OnHasPendingTreeStateChanged(bool has_pending_tree) = 0;
virtual void SetNeedsRedrawOnImplThread() = 0;
@@ -74,7 +74,8 @@
virtual bool IsInsideDraw() = 0;
virtual void RenewTreePriority() = 0;
virtual void RequestScrollbarAnimationOnImplThread(base::TimeDelta delay) = 0;
- virtual void DidReceiveLastInputEventForVSync(base::TimeTicks frame_time) = 0;
+ virtual void DidReceiveLastInputEventForBeginFrameOnImplThread(
+ base::TimeTicks frame_time) = 0;
virtual void DidActivatePendingTree() = 0;
protected:
@@ -124,7 +125,7 @@
base::TimeDelta duration) OVERRIDE;
virtual void ScheduleAnimation() OVERRIDE;
virtual bool HaveTouchEventHandlersAt(gfx::Point viewport_port) OVERRIDE;
- virtual void DidReceiveLastInputEventForVSync(
+ virtual void DidReceiveLastInputEventForBeginFrame(
base::TimeTicks frame_time) OVERRIDE;
// TopControlsManagerClient implementation.
@@ -205,7 +206,8 @@
virtual void SetNeedsRedrawRect(gfx::Rect rect) OVERRIDE;
virtual void OnVSyncParametersChanged(base::TimeTicks timebase,
base::TimeDelta interval) OVERRIDE;
- virtual void DidVSync(base::TimeTicks frame_time) OVERRIDE;
+ virtual void BeginFrame(base::TimeTicks frame_time)
+ OVERRIDE;
virtual void OnSendFrameToParentCompositorAck(const CompositorFrameAck& ack)
OVERRIDE;
@@ -229,7 +231,7 @@
const RendererCapabilities& GetRendererCapabilities() const;
virtual bool SwapBuffers(const FrameData& frame);
- void EnableVSyncNotification(bool enable);
+ void SetNeedsBeginFrame(bool enable);
void Readback(void* pixels, gfx::Rect rect_in_device_viewport);