win: Move Crashpad all into chrome.exe
This initializes Crashpad much earlier at the beginning of WinMain,
which captures early crashes about as well as we can. It also removes
all Crashpad code from chrome.dll and chrome_child.dll.
The cost for this is one thunk function that's looked up in
crash_upload_list_crashpad.cc to get back into chrome.exe (for its
global ChromeCrashReporterClient). That part is a little icky, but I
think it's worthwhile to get initialization before anything in the DLL
is run.
[email protected], [email protected]
BUG=546288, 561653, 564328
Review URL: https://codereview.chromium.org/1481703002 .
Cr-Commit-Position: refs/heads/master@{#363097}
diff --git a/chrome/browser/BUILD.gn b/chrome/browser/BUILD.gn
index 22dc1a5..d3e319e 100644
--- a/chrome/browser/BUILD.gn
+++ b/chrome/browser/BUILD.gn
@@ -622,7 +622,7 @@
} else {
sources -= [ "password_manager/password_store_x.cc" ]
}
- if ((is_posix && !is_mac && !is_ios) || is_win) {
+ if (is_posix && !is_mac && !is_ios) {
sources += [
"//chrome/app/chrome_crash_reporter_client.cc",
"//chrome/app/chrome_crash_reporter_client.h",
