Only build sad tab when status is crashed or killed.
When tab is closed normally by click x button, its status is
TERMINATION_STATUS_STILL_RUNNING in RenderViewGone().
This status makes sad tab building.
BUG=None
TEST=Compile, manual test
Review URL: https://chromiumcodereview.appspot.com/11192067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162847 0039d316-1c4b-4281-b951-d872f2087c98
diff --git a/chrome/browser/ui/sad_tab_helper.cc b/chrome/browser/ui/sad_tab_helper.cc
index 07fcacd0..dad8204a 100644
--- a/chrome/browser/ui/sad_tab_helper.cc
+++ b/chrome/browser/ui/sad_tab_helper.cc
@@ -46,14 +46,13 @@
if (browser_shutdown::GetShutdownType() != browser_shutdown::NOT_VALID)
return;
- // Don't build the sad tab view when the termination status is normal.
- if (status == base::TERMINATION_STATUS_NORMAL_TERMINATION)
- return;
-
if (HasSadTab())
return;
- InstallSadTab(status);
+ if (status == base::TERMINATION_STATUS_ABNORMAL_TERMINATION ||
+ status == base::TERMINATION_STATUS_PROCESS_WAS_KILLED ||
+ status == base::TERMINATION_STATUS_PROCESS_CRASHED)
+ InstallSadTab(status);
}
void SadTabHelper::Observe(int type,
