Google Git
Sign in
chromium / chromium / src / cbbd7543f9713f37effea6b6849bce3f4e83c9b4
commitcbbd7543f9713f37effea6b6849bce3f4e83c9b4[log] [tgz]
authorChong Zhang <[email protected]>Fri Mar 09 18:32:14 2018
committerCommit Bot <[email protected]>Fri Mar 09 18:32:14 2018
tree4c3044afcd24ec5912b8fdaba3f8619ff249caea
parent1f0de4545d9926e1e50a62ccfdf448d867a7f7ea [diff]
NetworkService: Fix 7 DevToolsDownloadContentTest cases

This CL:
1. Replaced |URLRequestInterceptor| usages with
   |embedded_test_server()| as the former is not supported in
   NetworkService.
2. Introduced |DownloadManager::Observer::OnDownloadDropped()| which is
   called when the download manager intercepted a download navigation
   but didn't create a download item.
3. Removed the following test cases from the filter:
-DevToolsDownloadContentTest.MultiDownload
-DevToolsDownloadContentTest.DefaultDownload
-DevToolsDownloadContentTest.ResetDownloadState
-DevToolsDownloadContentTest.DownloadCancelled
-DevToolsDownloadContentTest.DeniedDownload
-DevToolsDownloadContentTest.DefaultDownloadHeadless
-DevToolsDownloadContentTest.SingleDownload

Bug: 729848
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I9da96982ea8b5d0b4848f438a1f3a5bd8418dd72
Reviewed-on: https://chromium-review.googlesource.com/956560
Reviewed-by: Min Qin <[email protected]>
Reviewed-by: John Abd-El-Malek <[email protected]>
Commit-Queue: Chong Zhang <[email protected]>
Cr-Commit-Position: refs/heads/master@{#542173}
4 files changed
tree: 4c3044afcd24ec5912b8fdaba3f8619ff249caea
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_cleaner/
  11. chrome_elf/
  12. chromecast/
  13. chromeos/
  14. cloud_print/
  15. components/
  16. content/
  17. courgette/
  18. crypto/
  19. dbus/
  20. device/
  21. docs/
  22. extensions/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. mash/
  33. media/
  34. mojo/
  35. native_client_sdk/
  36. net/
  37. notification_helper/
  38. pdf/
  39. ppapi/
  40. printing/
  41. remoting/
  42. rlz/
  43. sandbox/
  44. services/
  45. skia/
  46. sql/
  47. storage/
  48. styleguide/
  49. testing/
  50. third_party/
  51. tools/
  52. ui/
  53. url/
  54. .clang-format
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .vpython
  61. AUTHORS
  62. BUILD.gn
  63. CODE_OF_CONDUCT.md
  64. codereview.settings
  65. DEPS
  66. ENG_REVIEW_OWNERS
  67. LICENSE
  68. LICENSE.chromium_os
  69. OWNERS
  70. PRESUBMIT.py
  71. PRESUBMIT_test.py
  72. PRESUBMIT_test_mocks.py
  73. README.md
  74. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .