| commit | cdb9949f95f46f09f906e289ece4fa0a9374bc0a | [log] [tgz] |
|---|---|---|
| author | danakj <[email protected]> | Fri Jun 21 02:03:48 2019 |
| committer | Commit Bot <[email protected]> | Fri Jun 21 02:03:48 2019 |
| tree | 3a4f1408010cc4bf0b877551268295adea38df24 | |
| parent | d35067ba1e292ed425ec2f6ae0205bdde22aea0e [diff] |
Move helper methods and BROWSER_TESTS_FLAGS to NativeBrowserTest. This adds a NativeBrowserTest helper class for sharing code between content and chrome browser tests. ChromeBrowserTestActivity is going to have to inherit from ChromeTabbedActivity so NativeBrowserTestActivity will no longer be a suitable place for sharing code. I will collapse it back into ContentShellBrowserTestActivity again in the future. For now, shared code moves out of NativeBrowserTestActivity so that ChromeBrowserTestActivity can change its inheritance. We clarify the ordering in onCreate() so that when the subclass uses async startup we can be sure that browser initialization and runTests() all occur after super.onCreate() by moving that call to the top of the onCreate() override. mTest.postStart() is moved out to runTests() though it is called directly from onCreate() for now. The call will move to the subclass when it uses async initialization. [email protected] Bug: 961849 Change-Id: I892a382643e0d8e3029fcac0a406225829cd3ad0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670407 Commit-Queue: danakj <[email protected]> Reviewed-by: John Budorick <[email protected]> Cr-Commit-Position: refs/heads/master@{#671171}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .