Introduce a stable set of errors for inline install
In addition to a developer-readable string for inline install failures, include
a stable error code. This isn't perfect, since a) the function prototype of
function(error, errorCode) isn't great, and b) we kind of lose track of what
went wrong after a certain point in the install process. Unfortunately, to fix
a) requires either a breaking change or a revamp to our whole error reporting,
and fixing b) requires stable error values at every point in our install
process (which we don't have, and won't anytime soon).
BUG=331887
[email protected] (app_list)
[email protected] (file_manager)
TBRs for trivial, no-functionality changes.
Review URL: https://codereview.chromium.org/384823002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285029 0039d316-1c4b-4281-b951-d872f2087c98
diff --git a/chrome/browser/extensions/tab_helper.h b/chrome/browser/extensions/tab_helper.h
index 9725f21..5793184 100644
--- a/chrome/browser/extensions/tab_helper.h
+++ b/chrome/browser/extensions/tab_helper.h
@@ -15,6 +15,7 @@
#include "base/memory/weak_ptr.h"
#include "base/observer_list.h"
#include "chrome/browser/extensions/active_tab_permission_granter.h"
+#include "chrome/common/extensions/webstore_install_result.h"
#include "chrome/common/web_application_info.h"
#include "content/public/browser/notification_observer.h"
#include "content/public/browser/notification_registrar.h"
@@ -224,7 +225,8 @@
virtual void OnInlineInstallComplete(int install_id,
int return_route_id,
bool success,
- const std::string& error);
+ const std::string& error,
+ webstore_install::Result result);
// content::NotificationObserver.
virtual void Observe(int type,
