| commit | d0d96f0f85b736c4310662b7cd88be2546d3a6b6 | [log] [tgz] |
|---|---|---|
| author | Christian Dullweber <[email protected]> | Wed Sep 13 09:22:51 2017 |
| committer | Commit Bot <[email protected]> | Wed Sep 13 09:22:51 2017 |
| tree | e95dd6ccb4a52baf28d53084c51ae46cbc5cf3b6 | |
| parent | e0911d2705a91fdddc1941cd4778bed75d24936f [diff] [blame] |
Split the CBD dialog into a basic and advanced tab To simplify the Clear Browsing Data ui on desktop, we introduce a basic section with the most frequently used options and an advanced section showing the existing options as well as an additional "Site settings" checkbox. The footers are removed and their information is integrated into the checkbox descriptions in the basic tab. This change requires a few additions to cr_dialog to inject a tab bar and restrict the dialog to a fixed height. SettingsCheckbox requires an additional attribute to add html with links to the summary. https://screenshot.googleplex.com/TvDGxE77XUC.png https://screenshot.googleplex.com/CvF0kx7UwSY.png Bug: 725401 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ic2a84d468d9e4fd74c225d8a3668d8d1663f8da6 Reviewed-on: https://chromium-review.googlesource.com/580987 Commit-Queue: Christian Dullweber <[email protected]> Reviewed-by: Martin Šrámek <[email protected]> Reviewed-by: Michael Giuffrida <[email protected]> Reviewed-by: Dave Schuyler <[email protected]> Cr-Commit-Position: refs/heads/master@{#501574}
diff --git a/chrome/browser/flag_descriptions.h b/chrome/browser/flag_descriptions.h index a005ac1..8a1e956 100644 --- a/chrome/browser/flag_descriptions.h +++ b/chrome/browser/flag_descriptions.h
@@ -792,6 +792,9 @@ extern const char kTabAudioMutingName[]; extern const char kTabAudioMutingDescription[]; +extern const char kTabsInCbdName[]; +extern const char kTabsInCbdDescription[]; + extern const char kTcpFastOpenName[]; extern const char kTcpFastOpenDescription[]; @@ -1198,9 +1201,6 @@ extern const char kSpannableInlineAutocompleteName[]; extern const char kSpannableInlineAutocompleteDescription[]; -extern const char kTabsInCbdName[]; -extern const char kTabsInCbdDescription[]; - extern const char kTranslateCompactUIName[]; extern const char kTranslateCompactUIDescription[];
